Support for node v12.x about node-oom-heapdump HOT 8 CLOSED

See fac8e92
These were:

• --optimize_for_size
• --always_compact

from node-oom-heapdump.

Hi @dhessler,

Yes, the company i work for is planning to move to Node 12 when it becomes LTS in october.
Part of that upgrade is making sure this module works on 12 as well.

So yes, i expect to add support for Node 12 in the near future.

Regards,

from node-oom-heapdump.

I haven't been able to test it thoroughly, but i managed to modify the native code to compile for Node.js 12. I've committed my code in a branch (node12) and published a "beta" version on npm, to test with.

See https://www.npmjs.com/package/node-oom-heapdump/v/1.2.0-beta.0.
Let me know what your experiences are.

UPDATE:

<--- Last few GCs --->

[83:0x3af7320]     1265 ms: Mark-sweep 79.9 (81.3) -> 79.6 (80.8) MB, 59.9 / 0.0 ms  (+ 22.0 ms in 16 steps since start of marking, biggest step 17.4 ms, walltime since start of marking 98 ms) (average mu = 0.460, current mu = 0.169) allocation failure sc[83:0x3af7320]     1358 ms: Mark-sweep 79.8 (80.8) -> 79.4 (80.8) MB, 75.9 / 0.0 ms  (+ 11.8 ms in 2 steps since start of marking, biggest step 11.8 ms, walltime since start of marking 92 ms) (average mu = 0.300, current mu = 0.053) allocation failure sca

<--- JS stacktrace --->
Cannot get stack trace in GC.


#
# Fatal error in , line 0
# unreachable code
#
#
#
#FailureMessage Object: 0x7fe869953880[2019-09-02T13:15:45+01:00]

It looks like i'll need to dig a little deeper; creating a heapdump through the v8 API causes a FATAL error on Node12, where this used to work earlier.

from node-oom-heapdump.

wow thanks @paulrutter for the quick investigation! definitely happy to beta test when ready.

from node-oom-heapdump.

I'm having a hard time getting it to work on Node.js 12.x.
See nodejs/node#27552 (comment).

I think i'll need help from the v8 team in order to proceed.
It seems that the API's haven't changed, but the context in which the API is called no longer seems to work on Node.js 12.

To be continued.

from node-oom-heapdump.

@dhessler after investigation, it looks like the combination of node startup flags i was using for my test case, caused the module to be unstable on nodejs 12.
Although this is not as it should be (i'm waiting on response from the nodejs team), it does work when not using those flags.

So, i would suggest we start using it on Node 12, to gather hands on experience with it.
If you encounter any issues, please let me know.

I will start using it in the next couple of months for sure.
Version 1.2.0 is now published to npm :)

from node-oom-heapdump.

I'm closing the issue for now.
Let me know when you encounter any issues by filing a new issue.

from node-oom-heapdump.

@paulrutter Which were the flags causing Node 12 to run badly? I'm having the same problem with v2.0.0 on Node 12.10.

from node-oom-heapdump.