Giter Club home page Giter Club logo

Comments (7)

naturalethic avatar naturalethic commented on May 8, 2024

More specifically, using flowtype types on component props breaks the buildProps function.

from react-bluekit.

imtoo avatar imtoo commented on May 8, 2024

Hi, can you send us link or code of your component that breaks the build? Thanks.

from react-bluekit.

naturalethic avatar naturalethic commented on May 8, 2024

The primary issue is that flowtype types are reported with a different property name than PropType types. We've decided to not use flowtype for now, due to this and other incompatibilities, but a quick hack demonstrated in the following commit got it to compile properly.

https://github.com/naturalethic/react-bluekit/commit/69cf095b2b4218437a02add8fbd5ea4cba4346c2

from react-bluekit.

imtoo avatar imtoo commented on May 8, 2024

Good point! I've created PR #90. Thanks for the feedback and commit! It will be in upcoming release.

from react-bluekit.

kjg531 avatar kjg531 commented on May 8, 2024

Is this confirmed working? I tried to switch out one of the examples proptypes for flowtypes and it doesn't seem to pick anything up.

from react-bluekit.

imtoo avatar imtoo commented on May 8, 2024

Yea, it was working when we tried it. It's part of v0.3.1 release. Here's parser doc https://github.com/reactjs/react-docgen#flow-type-support

from react-bluekit.

kjg531 avatar kjg531 commented on May 8, 2024

Does anyone have a example component working with flow?

from react-bluekit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.