file.GetFiles making the game unresponsive about blt4l HOT 23 CLOSED

I didn't give you push rights. I gave you collab rights, because you seem to be able to get to issues quickly and help people out. That way you should be able to close/mark issues.

from blt4l.

That's strange. Could you archive a copy of your mods folder and post it here, please?

I've had a few mods behave like this, as they expect file paths to be case-insensitive, but very few actually do.

What's odd here is that it shouldn't be affecting the BLT base.

from blt4l.

I just tested a fresh mods folder and it works fine, so It must be a mod which I'm not sure how that works. But it is. I'll do some more investigation.

from blt4l.

Seems there is an issue in BeardLib, not completely sure on what it is due to the lack of helpful errors in the console.

from blt4l.

I've found it, the issue is in file.GetFiles. Just calling it sends the game into the entire loop that I reported. Renaming the issue.

from blt4l.

Interesting. I'll look in to it when I get home.

from blt4l.

@GreatBigBushyBeard can you please point me to the file/line in BeardMod where you found this to cause problems so that I can use it as a test case to fix this?

from blt4l.

@RomanHargrave This line, https://github.com/GreatBigBushyBeard/PAYDAY-2-BeardLib/blob/dev/mods/BeardLib/BeardLibCore.lua#L191

It is mainly to do with the mod_overrides folder, so you'll probably need one for testing it.

from blt4l.

Out of curiosity, is mod_overrides working for you?

How about voice chat?

If they do, what distro/linux kernel/etc are you using?

Neither are BLT-related issues, but nonetheless, I have them, and overkill has been of little help. I was going to see if it was an environment issue.

from blt4l.

It does not work for me, if you're wondering what BeardLib is doing with it, it loads any Script Data files in mod_overrides and replaces them when they are requested by the PackageManager:script_data func.

I haven't tried voice chat yet, but I'll try and test it if I can remember.

Regarding the mod_overrides folder, I contact Overkill today about the issue, but I haven't got a reply back yet.

For future reference, I've got my Payday setup using symbolic links to connect my assets and mods folder between my Linux and Windows install. It's unlikely that it will be relevant to the issue at hand, but anything is possible.

from blt4l.

mod_overrides isnt actually "broken". it's not even meant to be working on linux yet.

from blt4l.

@BangL Elaborate

from blt4l.

there isnt even a "mods" entry in the menu.
pretty sure its just overkill's lazyness though.

from blt4l.

@BangL I'm fairly certain it only appears when mod_override mods are installed.

from blt4l.

..oh well that actually makes sense. i'm taking it back then.. might be just broken then.

from blt4l.

well... the bundles are the same on linux, so the lua code must be the same as well.
i just grep'ed the pd2 lua code recursively and case insensitive and there is not a single occurrence of "mod_override"... so its part of the binary, which is pretty much the only difference on linux..

however, when i grep the linux-binary for "mod_overrides", there are actually 7 occurrences.

so yea. seems broken, you're right.

from blt4l.

@BangL I doubt Overkill would have tested it before release, considering they don't really use mods and the feature was kinda just shoved in. Hopefully we can get it resolved soon though.

And yes, the mod_override stuff is engine side. As far as I remember the lua code gets the mods by DB:mods(), and there are a few functions engine side which handle the mod_overrides.

from blt4l.

@BangL I poked at the application binary and it appears that mod_overrides is handled that way. There are several namespaces and functions that refer to it.

from blt4l.

OK. Granted I have not tested this with the affected mods, it looks like list_files, the logic used for getdirectory was leaking a dirstream. I've fixed that at commit c4c8962. Let me know if that changes any behaviour, for better or worse.

from blt4l.

..uhm what?
i think we have a misunderstanding here. i don't need push right's at all, overkill needs to fix it.

from blt4l.

oh well, okay. seems legit.

from blt4l.

I would have messaged you, if it weren't for the fact that GH does not support messaging.

from blt4l.

@RomanHargrave I just built the current repository and it appears that the file.GetFiles issue has been fixed.

from blt4l.