Giter Club home page Giter Club logo

Comments (13)

Adamj1232 avatar Adamj1232 commented on June 21, 2024 1

@ignromanov I am still unable to reproduce the disconnect error - I made a video of what I am seeing when trying this locally. https://www.loom.com/share/3d73a7ccfa1645cb9deb820fb8ea438c?sid=93f5efb4-5539-4075-a204-c9ea9dcea605
Might be good to confirm you are on the latest version of "@web3-onboard/injected-wallets": "^2.11.1"

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on June 21, 2024 1

@ignromanov ahh ok I think I got it figured out, required a local storage clear to reproduce. Looking into this today. Will have a fix shortly.

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on June 21, 2024 1

@ignromanov please give this a shot with the latest alpha version of @web3-onboard/core or framework package noted in the PR above - would love validation on your end prior to release

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on June 21, 2024

Hi @logsdk can you provide more context for me around what this code is trying to do?

from web3-onboard.

ignromanov avatar ignromanov commented on June 21, 2024

Hi.
The same issue.
You need to connect to the DApp using Rabby wallet.
After pressing the disconnect button (calling the disconnect function) - an error is thrown.

  const [{ wallet }, disconnect] = useConnectWallet()
  await disconnect(wallet)

The reason is that the onboard.js:last_connected_wallet key is missing from the local storage

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on June 21, 2024

@ignromanov Disconnect using the approach as shown above working without issue on our demo sites - https://github.com/blocknative/react-demo/blob/89509379f4cd09299b45b2301769aa80a7c58991/src/App.js#L543
If you can provide more code for context I can assist further

from web3-onboard.

ignromanov avatar ignromanov commented on June 21, 2024

The reason was that flags autoConnectLastWallet and autoConnectAllPreviousWallet were false during onboard initialization

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on June 21, 2024

@ignromanov does that mean we can close this issue?

from web3-onboard.

ignromanov avatar ignromanov commented on June 21, 2024

@Adamj1232 I think you should test with these flags set to False. You will get a disconnect error.

from web3-onboard.

ignromanov avatar ignromanov commented on June 21, 2024

@Adamj1232 I tried it on your test application. Try with these changes to reproduce it. I got an error.

image

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on June 21, 2024

@ignromanov I am still unable to reproduce an error with that change

from web3-onboard.

ignromanov avatar ignromanov commented on June 21, 2024

@Adamj1232 Recorded a video reproduction of the error. Launched your repository with the change described above.

Screen.Recording.2024-06-14.at.22.53.38.mov

from web3-onboard.

satoshisafedevs avatar satoshisafedevs commented on June 21, 2024

We are seeing this same issue with the latest version on all packages and brave browser.

from web3-onboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.