Comments (10)
And also why is platform restricted to desktop for okx wallet?
from web3-onboard.
@puderty the OKX wallet integration was done by the OKX team. If you would like to open a PR to add mobile support and test please feel free to do so.
otherProvidersFlagsExists
method is necessary to reduce spoofing. Wallets should not set both flags to be true, this is bad UX and misleading users. MetaMask is the only wallet that should set isMetaMask
to true and MetaMask should be the only wallet that opens if the user selects MetaMask.
Im not sure what you mean by MetaMask compatible, can you please clarify?
from web3-onboard.
For some dapp not using your sdk, and if they only integrate with metamask, if we don't set ismetamask to true, the dapp cannot connect to okx mobile wallet. So we have to set it for compatible reason, but your check will broken it and make it cannot connect by click on metamask when using blocknative.
I'm from okx wallet mobile team, if otherProvidersFlagsExists is necessary, can you change the platform from desktop to all for okx wallet?
from web3-onboard.
@puderty set it for compatible reason
is spoofing and is a misleading UX.
If you are from the OKX team please pass this along to the dev team.
If the wallet is to be used the provider flag needs to be specified and not rely upon MetaMask to mislead people into selecting one wallet and getting another.
I opened a PR to update the devices for OKX: #1901
from web3-onboard.
But can we remove otherProvidersFlagsExists on mobile? Because the on mobile app there should be only one injected ethereum object and it's injected by the mobile web3 wallet the user is using.
from web3-onboard.
@puderty that update was made as part of this PR - https://github.com/blocknative/web3-onboard/pull/1901/files and will be merged into staging shortly.
This should allow OKX wallet to display properly on mobile. We wont be removing otherProvidersFlagsExists
from MetaMask as this is to avoid spoofing of wallets.
from web3-onboard.
Can you add some flag under window object so we can check that the dapp is using this library? So we can avoid setting other flags for dapps using this library. Such as window.isUsingBlockNative = true.
from web3-onboard.
We don't alter the provider object on the window so there is not a flag we can set. Please try using the latest alpha packages of core, react or vue to see if the update to the device settings for OKX wallet solves the issue - See #1901 for those versions
from web3-onboard.
@puderty support should be stabilized with a release going out today. We would be interested in doing a marketing post to our community around wallet support. Feel free to reach out for a contact within Blocknative if interested
from web3-onboard.
Sure. I still suggest we remove the check on mobile, because for every mobile web3 wallet, there's only one injected window.ethereum, and every wallet should do their best to help their users to connect the dapp to the wallet. A lot of dapps only show Metamask as the only option.
There's no spoofing on mobile web3 wallet or mobile browser.
from web3-onboard.
Related Issues (20)
- WalletConnect fails to connect when both icon and logo are large SVGs HOT 2
- wallectConnect not working HOT 5
- CORS issue with Ledger HOT 6
- disableModals doesn't work with WalletConnect HOT 1
- Uncaught TypeError: Failed to resolve module specifier "@web3-onboard/core". Relative references must start with either "/", "./", or "../". HOT 1
- Error: To use QR modal, please install @walletconnect/modal package HOT 2
- WalletConnect demo not working HOT 2
- My project
- ERROR in ./node_modules/@web3-onboard/core/dist/Index-a8f5e52f.js | Module parse failed: Unexpected token (2148:140) | Vue2 + Nuxt HOT 5
- state is not defined ReferenceError: state is not defined
- UI attempts to display even when not connected
- Update Onboard Ledger Connect Kit deps HOT 2
- Import error in Angular with @web3-onboard/walletconnect
- [Feature]:
- Coinbase Connect issue with blacklisting Dapp HOT 1
- [Bug] MetaMaskSDK `extensionOnly: true` breaks the connecting to MetaMask HOT 1
- yarn add @web3-onboard/core @web3-onboard/injected-wallets ethers HOT 2
- [Feature]: Enable Dependabot Security Updates
- await connect() returns before it's connected HOT 4
- [Feature]: Update outdated and vulnerable crypto-es module HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web3-onboard.