Giter Club home page Giter Club logo

Comments (13)

peterpan0708 avatar peterpan0708 commented on September 23, 2024 1

@peterpan0708 I tried on both site 10x across multiple browsers and was unable to reproduce. Can you create a reproducible example or video?

2_1688692669.mp4

from web3-onboard.

peterpan0708 avatar peterpan0708 commented on September 23, 2024 1

@Adamj1232
more information:
image
our code stuck at this line
go deep into the source code
41688697058_ pic
requestAccounts() doesn't return

from web3-onboard.

digitalmnt avatar digitalmnt commented on September 23, 2024 1

@schultztimothy we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed. This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property. I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this. To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

This fix worked for us!

We are experiencing issues still with using gnosis safe's wallet. Not sure if you have had any other reports of this

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on September 23, 2024

@peterpan0708 I tried on both site 10x across multiple browsers and was unable to reproduce.
Can you create a reproducible example or video?

from web3-onboard.

peterpan0708 avatar peterpan0708 commented on September 23, 2024

@peterpan0708 I tried on both site 10x across multiple browsers and was unable to reproduce. Can you create a reproducible example or video?

2_1688692669.mp4

I think it's a common issue, because all of our team members can reproduce

from web3-onboard.

digitalmnt avatar digitalmnt commented on September 23, 2024

I'm also experiencing this error:
Screenshot 2023-07-07 at 11 15 40 AM
Screenshot 2023-07-07 at 11 16 56 AM

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on September 23, 2024

@schultztimothy I think this is a different error than what is reported in this issue.
The error you are noted we are aware of and we are troubleshooting with the walletconnect and metamask teams.
Are you a dev with curve.fi?

from web3-onboard.

digitalmnt avatar digitalmnt commented on September 23, 2024

@schultztimothy I think this is a different error than what is reported in this issue. The error you are noted we are aware of and we are troubleshooting with the walletconnect and metamask teams. Are you a dev with curve.fi?

Thanks for your quick response! I'm not with Curve, but am a dev on Gitcoin's passport application and we are experiencing the same issue. We recently updated to "@web3-onboard/walletconnect": "2.4.0", and are about to release the update.

I assume since you all are actively working on it we should be good to release and the issue should be patched soon? Thanks again!

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on September 23, 2024

@schultztimothy we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed.
This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property.
I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this.
To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

from web3-onboard.

peterpan0708 avatar peterpan0708 commented on September 23, 2024

@schultztimothy we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed. This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property. I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this. To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

Hi, do you reproduce the Connecting... issue?
Is there any progress?
Thanks for the reply.
@Adamj1232

from web3-onboard.

taylorjdawson avatar taylorjdawson commented on September 23, 2024

@peterpan0708 Did the release which included this PR resolve your issue?

from web3-onboard.

peterpan0708 avatar peterpan0708 commented on September 23, 2024

@peterpan0708 Did the release which included this PR resolve your issue?

no, this PR is about walletconnect, not reslove this issue

from web3-onboard.

Adamj1232 avatar Adamj1232 commented on September 23, 2024

@peterpan0708 is this still an issue after updating your local version of MetaMask extension to the latest version?

from web3-onboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.