Giter Club home page Giter Club logo

Comments (8)

taylorjdawson avatar taylorjdawson commented on September 23, 2024 3

Hey @CuriouslyCory thanks for bringing this to our attention, we'll take a look at your example see what the issue is. We don't have many angular users so but this will benefit those who do use it 👍

from web3-onboard.

glitch-txs avatar glitch-txs commented on September 23, 2024 2

I think you can try
// @ts-nocheck – ignore <package-name>
On top of your files before importing

Seems to be a conflict with typescript config that might come from wagmi or web3modal.
https://wagmi.sh/core/typescript

from web3-onboard.

CuriouslyCory avatar CuriouslyCory commented on September 23, 2024 1

Looks like @ts-nocheck is one of those hyperlocal things. I messed around with it a few different ways but the skipLibCheck is still my main workaround for now.
Thanks again.

from web3-onboard.

CuriouslyCory avatar CuriouslyCory commented on September 23, 2024

Thank you!

I just tried installing with yarn and got the same results.

I'm not super experienced with projects like this, but it looks like there are a number of deps missing from package.json files, or miscatagorized as devDependencies when they should be runtime deps.
e.g. common/package.json has eventemitter3, and eip-721 as dev deps, but they appear to be included in runtime files.

from web3-onboard.

glitch-txs avatar glitch-txs commented on September 23, 2024

Hey could you try adding "skipLibCheck": true in the ts.config file?

from web3-onboard.

CuriouslyCory avatar CuriouslyCory commented on September 23, 2024

@glitch-txs Yes, that does stop the errors!

I'm not sure I'm comfortable leaving it on for my entire project, but it is a viable workaround for the time being and I'll look deeper into what the skipLibCheck is doing and if there's any way to apply it to specific dependencies.

Thank you!

from web3-onboard.

RronKurtishi avatar RronKurtishi commented on September 23, 2024

Facing the same issues with Angular 16. Changed the import path from packages to @walletconnect to solve the first two errors.

I also installed eip-712, @web3-onboard/gas, @web3-onboard/unstoppable-resolution and @web3-onboard/transaction-preview (added to dependencies in package.json) to solve the other errors.

The last two errors are from @web3modal which I haven't integrated.

Manually editing packages is not the best solution, but still better than "skipLibCheck": true.

from web3-onboard.

RronKurtishi avatar RronKurtishi commented on September 23, 2024

Issue is fixed on @web3-onboard/[email protected]

from web3-onboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.