Comments (6)
mchlcrtz
commented on May 28, 2024
1
@schnogz I would like to get on this when I can! It looks like they are mostly in the container files. Would you have a preference on where to start?
from blockchain-wallet-v4-frontend.
schnogz
commented on May 28, 2024
@mchlcrtz that would be great. Some of the easiest spots would be in the Security Center. blockchain-wallet-v4-frontend/src/scenes/SecurityCenter/~. Feel free to open PRs whenever it makes sense and as needed
from blockchain-wallet-v4-frontend.
mchlcrtz
commented on May 28, 2024
Hi @schnogz, should I be adding my own sagas in blockchain-wallet-v4-frontend/src/data? If so, can you describe the design of data flow in that directory? Thank you!
Also, with simple ui state changes such as toggling, would it be okay to handle them with normal actions/reducers?
from blockchain-wallet-v4-frontend.
schnogz
commented on May 28, 2024
I think most code that uses redux-ui is pretty simple stuff such as toggle states and what not. You can just use the standard react component state to handle all this. Here is an example:
https://github.com/blockchain/blockchain-wallet-v4-frontend/blob/9a9a5cdc9d52b244d71b1b3197fd2a7b81d78b39/packages/blockchain-info-components/src/Dropdowns/SimpleDropdown/index.js
Edit: I see that you have already made a PR for some of this using redux. I will take a look later today but we probably want to redo it to use just react states. sorry about that man.
from blockchain-wallet-v4-frontend.
plondon
commented on May 28, 2024
Can we close this?
from blockchain-wallet-v4-frontend.
plondon
commented on May 28, 2024
Closing!
from blockchain-wallet-v4-frontend.
Related Issues (20)
- 1488800
- 1488800
- 1488800
- 1488800
- 1488800
- 1488800
- 1488800
- 1488800
- 1488800
- TypeError: Cannot read properties of undefined (reading 'current') at Transactions_selectors_getData when trying to access BTC portfolio HOT 2
- Has anyone else received these emails
- is good? HOT 1
- I guess I am plagered and I hear perhaps under attack. Cyber bully's STOP! . HOT 1
- 12 WORD SEED PHRASE NOT ACCEPTED ON BLOCKCHAIN.COM WALLET ALTHOUGH ITS CORRECT
- USDT
- I AM UNABLE TO TRANSFER BTC FROM MY TRADING ACCOUNT TO ANOTHER BITCOIN WALLET HOT 3
- Blockchain seperti taik🤣🤣☑️
- Tg
- 
- King
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blockchain-wallet-v4-frontend.