Giter Club home page Giter Club logo

Comments (4)

KevinCalderone avatar KevinCalderone commented on August 31, 2024

We've tried to keep the syntax compatible with both proto2 and proto3. Do you get errors when using the proto3 compiler?

from s2client-proto.

DenisJNewb avatar DenisJNewb commented on August 31, 2024

proto3 using zero based Enums;
data.proto contains:
enum Target {
None = 1; // Does not require a target.
Point = 2; // Requires a target position.
Unit = 3; // Requires a unit to target. Given by position using feature layers.
PointOrUnit = 4; // Requires either a target point or target unit.
PointOrNone = 5; // Requires either a target point or no target. (eg. building add-ons)
}
Im getting compile error.
Looks like if i manualy change None = 0 and etc. it will confuse system. Didnt it?

from s2client-proto.

jhugard avatar jhugard commented on August 31, 2024

Better to add Unknown = 0;

from s2client-proto.

KevinCalderone avatar KevinCalderone commented on August 31, 2024

I would be fine with adding an Unknown entry to our enums for compatibility. Are there any other proto3 errors?

from s2client-proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.