Blitz needs to restart after schema change and CRUD generated about blitz HOT 10 CLOSED

If we can get away with only modifying watched files in webpack then that would be simpler as to be reactive we would want to setup something that looks like a "next manager" to listen for a specific event and restart the server.

from blitz.

Hey @tconroy, I haven't added next-prisma-plugin yet because it's still experimental from prisma and I don't know if it works with webpack 5. Also it doesn't it with our globalThis caching which we still do inside enhancePrisma.

So need to test that prisma plugin with webpack 5 plus change it to work with globalThis.

from blitz.

if we can either find a JS tool similar to entr or leverage nodemon somehow it should be pretty easy to restart the sevrer there. Or maybe even reuse some logic from the synchronizer to detect changes? @ryardley thoughts?

from blitz.

So just reading this I would say the issue is that because prisma generates new types etc. and they aren't loaded into next. Perhaps we can flag certain file changes (prisma.schema perhaps?) as tabling a restart of next?

from blitz.

I suspect this is because prisma client is inside node_modules and Next doesn't expect files in there to change.

Maybe we only need to modify the webpack config?

from blitz.

Related blitz-js/legacy-framework#466

from blitz.

Is there a solution?

from blitz.

@clearink I think the original issue might be fixed. But regardless, I'm sure there's a way to fix it. No-one has had time to dig into it yet, but anyone is welcome to do so!

Our current new app template has this in db/index.ts

let prisma: PrismaClient

if (process.env.NODE_ENV === "production") {
  prisma = new PrismaClient()
} else {
  // Ensure the prisma instance is re-used during hot-reloading
  // Otherwise, a new client will be created on every reload
  global["prisma"] = global["prisma"] || new PrismaClient()
  prisma = global["prisma"]
}

export default prisma

That is so that we don't run out of too many db connections during hot code reloading in dev. But I think that also may prevent reloading the schema without a restart.

Could you try removing that and see if a restart if still needed for schema changes?

from blitz.

Solution is to add https://github.com/williamluke4/next-prisma-plugin to our withBlitz webpack wrapper and to remove the globalThis stuff from the new app template.

from blitz.

Hey @flybayer 👋 it seems the globalThis stuff has been removed from the app template since this ticket was originally opened. Does that mean the only remaining step is to add the next-prisma-plugin to withBlitz? Have a branch locally with that change, happy to push it up. :-)

from blitz.