Using --autoload cmdline option results in seg_fault about amiberry HOT 6 CLOSED

I cannot recreate this here:

Tested on Ubuntu and Manjaro Linux x86-64.
And it works on the ARM/ARM64 versions as well, of course (RetroPie uses this feature quite extensively)

from amiberry.

Hmmm....interesting ....which Ubuntu release was that? I can install locally on same hardware and compare

from amiberry.

TBH, I really DO expect my LFS builds to do the unexpected, and I likely wouldn't be here typing if that were only the case, but when I see the (stock, nothing special) Debian 10.13 doing the same thing, I have to wonder if the issue is related (segmentation fault share common ground)...

Firstly FTR ~ a fresh install of Debian 11.6, add dependencies as per amiberry github build instructions, git clone the amiberry tree and issue 'make PLATFORM=x86-64' , download AddamsFamily_v1.3_0419.lha and copy required kickstart roms into place, launch amiberry with ' ./amiberry --autoload AddamsFamily_v1.3_0419.lha ' ....works as expected.

To recreate the issue appears to be trivial for me;

Fresh install of Debian 10.13 (using --> https://gemmei.ftp.acc.umu.se/cdimage/unofficial/non-free/cd-including-firmware/archive/10.13.0+nonfree/amd64/iso-cd/firmware-10.13.0-amd64-netinst.iso) Normal install, just XFCE4 as WM (nothing else, no gnome etc), ssh server and general system utilities.

Start fresh system, install required tools & dependencies as per amiberry github build instructions, git clone the amiberry tree and issue 'make PLATFORM=x86-64' , download AddamsFamily_v1.3_0419.lha and copy required kickstart roms into place, and launch amiberry with ./amiberry --autoload AddamsFamily_v1.3_0419.lha ....segmentation fault.

[note: regarding github page the debian target for binary libserialport is "libserialport0" not "libserialport" ]

from amiberry.

//...can't believe I just found this.... you can recreate this by following on with the example above.

layout:

You've downloaded and compiled amiberry from git-master, so $HOMEDIR contains ~/amiberry

Copy AddamsFamily_v1.3_0419.lha to ~/amiberry/AddamsFamily_v1.3_0419.lha

Also have a copy of AddamsFamily_v1.3_0419.lha in $HOMEDIR ...ie; ~/AddamsFamily_v1.3_0419.lha

cd amiberry

./amiberry --autoload AddamsFamily_v1.3_0419.lha --> seg_fault

./amiberry --autoload ./AddamsFamily_v1.3_0419.lha --> game starts and runs

./amiberry --autoload ../AddamsFamily_v1.3_0419.lha --> game starts and runs

mkdir ~/amiberry/lha
mv AddamsFamily_v1.3_0419.lha ~/amiberry/lha/

./amiberry --autoload lha/AddamsFamily_v1.3_0419.lha --> game starts and runs

I only twigged this after seeing you'd done the same thing. I checked all this on the Debian 10.13 instance, and then recreated same (with same results) on my LFS 11.0 builds.

Question is, why is it so? It almost seems like amiberry has no fix on where cwd is?....weird.

I mean to say, it shouldn't need an explicit path to the whdload.lha file -- this is problematic when I try to create a default action for a downloaded whdload.lha file...ie; default action would be amiberry --autoload %f

Any fix for this?

TIA

from amiberry.

Command: valgrind -s amiberry.dbg --autoload AddamsFamily_v1.3_0419.lha

==2288== Invalid read of size 1
==2288== at 0x5359FDD: strstr (vg_replace_strmem.c:1790)
==2288== by 0x568973: whdload_auto_prefs(uae_prefs*, char*) (amiberry_whdbooter.cpp:1291)
==2288== by 0x3D3B89: parse_cmdline(int, char**) (main.cpp:964)
==2288== by 0x3D42E0: parse_cmdline_and_init_file(int, char**) (main.cpp:1059)
==2288== by 0x3D4BE8: real_main2(int, char**) (main.cpp:1237)
==2288== by 0x3D4F9B: real_main(int, char**) (main.cpp:1361)
==2288== by 0x542985: main (amiberry.cpp:3764)
==2288== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==2288==
==2288==
==2288== Process terminating with default action of signal 11 (SIGSEGV)
==2288== Access not within mapped region at address 0x0
==2288== at 0x5359FDD: strstr (vg_replace_strmem.c:1790)
==2288== by 0x568973: whdload_auto_prefs(uae_prefs*, char*) (amiberry_whdbooter.cpp:1291)
==2288== by 0x3D3B89: parse_cmdline(int, char**) (main.cpp:964)
==2288== by 0x3D42E0: parse_cmdline_and_init_file(int, char**) (main.cpp:1059)
==2288== by 0x3D4BE8: real_main2(int, char**) (main.cpp:1237)
==2288== by 0x3D4F9B: real_main(int, char**) (main.cpp:1361)
==2288== by 0x542985: main (amiberry.cpp:3764)

Note: LFS 11.3-x86-64 ; 'amiberry.dbg' is compiled with DEBUG=1 (git-master amiberry 5.6.1)

from amiberry.

@giantclambake
This was a bug after all - thanks to your details above, I managed to narrow it down and fix it.

from amiberry.