Giter Club home page Giter Club logo

Comments (3)

carloscabanero avatar carloscabanero commented on June 9, 2024 1

I need to check this but we can get it fixed before final release for 17.3.0

from blink.

carloscabanero avatar carloscabanero commented on June 9, 2024 1

So here is the thing. Although underscores are allowed in domain names, they are still not allowed in Host Names. Host names are limited to letters-digits-hyphens. Libssh follows this convention, I'm not sure if OpenSSH does though. When we are the ones replacing it (on the ProxyCommand example you sent), this is not an issue as we consider that an "Alias" and not a Hostname.

That being said, one thing is what the rules say and another what people are actually doing. We may need to take this to upstream. For the time being, if you want to have underscores, just don't use them at the ProxyJump itself.

I'm gonna leave this for a later release because I don't know if the "underscore" may actually break other things within LibSSH for 17.3.0 and we are about to release. If the issues had been parsing on our side, I would have had no problem making the change. Hope that makes sense.

Resources
https://git.libssh.org/projects/libssh.git/tree/src/misc.c#n2133
https://stackoverflow.com/questions/2180465/can-domain-name-subdomains-have-an-underscore-in-it/2183140#2183140

from blink.

brishav23 avatar brishav23 commented on June 9, 2024

I see, that makes sense. Thanks for checking that out; it doesn't really affect the usefulness of the app anyway 😆 as for OpenSSH, the reason I opened the issue was because the same config (with underscores for the ProxyJump) worked fine on my Mac with OpenSSH, but I didn't realize that might have been an OpenSSH-specific thing

from blink.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.