Comments (1)
Based on some digging I've done for #154, ISTM we may be better off removing the embedded http.Request
from r2.Request
and going back to a Request()
helper that creates a request on the fly. If not, we have to worry about mutations to an http.Request
that should have the same side affects that changes to http.NewRequest()
arguments would have (we could do this just by calling http.NewRequest()
and copying all the fields over, but this could be costly performance wise.
from go-sdk.
Related Issues (20)
- v2 bug: web.ViewCache() incorrectly claims to be cached after Parse failures HOT 1
- v2 logger swallows panic caused by `nil` HTTP request
- v3: `r2.OptTLSRootCAs()` has "typed nil" issue when checking for a nil transport HOT 1
- `r2` sends invalid HTTP requests if `Path` does not have a leading `/`. HOT 5
- v3: `web.Ctx.CookieDomain()` includes port
- Span type and span operation name for `oauthtrace` are generic HTTP
- [assert] Function doesn't compare equal to itself HOT 2
- Provide custom `CheckRedirect` for `r2.Request.Client`. HOT 3
- `r2.Request` should follow 307 on non-GET HOT 3
- Off-by-one error in line numbers in panic output from within a goroutine
- `make dev-deps` failing to install goreleaser HOT 4
- `log.Trigger()` buries panics HOT 2
- Port internal SDK changes to public `go-sdk` HOT 1
- crypto, only KeySize 32 is supported HOT 1
- `testutil` suite run silently aborts on panics in `OptBefore` hooks HOT 1
- Outdated modules that contains volunerabilities HOT 1
- SNYK-GOLANG-GITHUBCOMJACKCPGPROTO3V2-1316251
- dependency error go sdk HOT 1
- When ever Particular key has empty value in XFCC Header, It is parsing wrongly
- selector/runes.go: isAlpha not robust
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-sdk.