Message Link pings users again if they were pinged in the original message about yagpdb-cc HOT 12 CLOSED

Put simply, use the following trigger to achieve it not triggering with carats:
(?:[^<]|\A)https://(?:\w+\.)?discord(?:app)?\.com/channels\/(\d+)\/(\d+)\/(\d+)(?:[^>\d]|\z)

Apart from that, there is no good way to prevent this from happening as of now, given by how the allowed mentions field in messages work (blame Discord).

from yagpdb-cc.

re: https://github.com/BlackWolfWoof/yagpdb-cc/blob/master/Misc/message%20link.gotmpl

If the original message has a ping and an embed, yag recreates the message entirely, thus pinging all the users again.
This is really only an issue with messages from the Sesh event bot. So perhaps simply ignoring messages from this user would be a solution.

Alternatively, if stripping the pings is not doable, adding a function to ignore message links in carats( e.g. how <https://url.com> does not create an embed in discord), that could also work.

I love this custom command... It should be included by default in yag. So thanks for making it. I hope you could fix this, though!

Thank you.

Hmm i could get the id of the user and replace it with the name instead i guess. I'll think about it

from yagpdb-cc.

Just update the trigger in my opinion, is also more intuitive and simulates the behaviour Discord shows with normal links.

from yagpdb-cc.

Just update the trigger in my opinion, is also more intuitive and simulates the behaviour Discord shows with normal links.

But that would defeat the purpose of using message link to quote the message and display its content across channels

from yagpdb-cc.

i'll simply just add some fix to not ping users

from yagpdb-cc.

But that would defeat the purpose of using message link to quote the message and display its content across channels

How would that defeat the purpose?
With a normal link, say, https://youtube.com Discord will embed it, unless we enclose it in carets like so: <https://youtube.com>.
The new and updated trigger will exactly simulate that kind of behaviour, making it more intuitive than always embedding the message.

from yagpdb-cc.

The best case scenario is add a fix to not ping users and also keeping the modified trigger. The carats do allow some extra control from users. There are times when you want to link to a message and not initiate a preview from yag.

from yagpdb-cc.

Put simply, use the following trigger to achieve it not triggering with carats:
(?:[^<]|\A)https://(?:\w+\.)?discord(?:app)?\.com/channels\/(\d+)\/(\d+)\/(\d+)(?:[^>\d]|\z)

Apart from that, there is no good way to prevent this from happening as of now, given by how the allowed mentions field in messages work (blame Discord).

This appears to not work at all -
no messages are previewed anymore. If it is only a link with no message, it simply deleted the message without giving a preview.
The bot does ignore the carats if they're used, but does not provide previews when no carats are used.

from yagpdb-cc.

Works perfectly fine on my end...
You aren't hitting custom command limits (3 per event)?

from yagpdb-cc.

P.S.: Sounds more like a code issue to me, try using the latest code if you aren't already.

from yagpdb-cc.

Ended up being something completely different - #19

from yagpdb-cc.

Note to myself: Use .Message.Mentions and getMember everyone and check if they are still on the server

from yagpdb-cc.