Comments (15)
I have a feeling it is a consequence of wrong start values. I have page.url eval differently with URL
http://localhost:4000/docs/getting-started/
With Java /docs/getting-started/index.md
With Ruby /docs/getting-started/index.html
from liqp.
Another combo is
http://localhost:4000/docs/getting-started/initial-configuration.html
from docs/getting-started/initial-configuration.md
Ruby: Home > Docs > Getting Started > Initial Configuration
Java: Home > Getting Started > /Docs >
from liqp.
Thanks Manfred, I'll have a look.
from liqp.
This has to do with the fact that there is a nested for
tag. The inner for
messes up the variables of the outer for
. Nasty one, let me think a bit on how to fix this bug.
from liqp.
@mosabua could you try the fix in #47 ?
from liqp.
I can try it next week when I am back at work..
from liqp.
Great! 👍
from liqp.
I tested this now with the 0.6.8-SNAPSHOT from the PR branch and that works!
from liqp.
So from my perspective you can merge and release. Let me know if you need help with the release to the Central Repository..
from liqp.
I tested this now with the 0.6.8-SNAPSHOT from the PR branch and that works!
Cool, I'll tidy up that branch and add some more unit tests for nested contexts soon. I've been a bit busy lately.
So from my perspective you can merge and release. Let me know if you need help with the release to the Central Repository..
Jason has been doing releases to Maven Central. If you're okay with it, I can ask him to provide you access as well. Then I'll give you push access to this repo and you can do releases too. Just let me know.
from liqp.
I work with Jason so I will chat with him when I get a hold of him.
from liqp.
Cool 👍
from liqp.
Ok, the fix is in master
and I've bumped the version. Feel free to release master
to the Central Repository.
I also added you as a collaborator in case you want to change versions before future releases and/or merge develop into master before releases.
Thanks!
from liqp.
Great. I will just have to sort out the Central access.
from liqp.
Release done.
from liqp.
Related Issues (20)
- Included template must be parsed/rendered with the same parse/rendering settins
- Future of @deprecated methods HOT 7
- How to convert to a JSON String HOT 4
- Upgrade ANTLR HOT 11
- Template errors not being stored when using liquid for loops HOT 2
- Support for Liquid's Layouts HOT 3
- Integer and Float Comparisons After Using Times Filter HOT 15
- How to modify default renderer HOT 1
- Shaded jar should exclude non-ANTLR dependencies HOT 2
- Support for `liquid` tag HOT 1
- expression errors ignored in _some_ cases HOT 1
- Template parse is deprecated HOT 3
- Issues with the new release. HOT 2
- != working as == HOT 2
- Is Template (render) thread safe? HOT 2
- when text contains UNICODE characters the parsing fails HOT 1
- Parser error "Invalid Tag: 'liquid'" HOT 2
- Support Instant datetime pattern
- Support for Instant, LocalDateTime date pattern HOT 1
- BlockNode Map render issue: String.valueOf(Map<?,?>) returns '=' instead of ':' as delimiter HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liqp.