Giter Club home page Giter Club logo

Comments (15)

mosabua avatar mosabua commented on June 20, 2024

I have a feeling it is a consequence of wrong start values. I have page.url eval differently with URL
http://localhost:4000/docs/getting-started/

With Java /docs/getting-started/index.md
With Ruby /docs/getting-started/index.html

from liqp.

mosabua avatar mosabua commented on June 20, 2024

Another combo is

http://localhost:4000/docs/getting-started/initial-configuration.html
from docs/getting-started/initial-configuration.md

Ruby: Home > Docs > Getting Started > Initial Configuration
Java: Home > Getting Started > /Docs >

from liqp.

bkiers avatar bkiers commented on June 20, 2024

Thanks Manfred, I'll have a look.

from liqp.

bkiers avatar bkiers commented on June 20, 2024

This has to do with the fact that there is a nested for tag. The inner for messes up the variables of the outer for. Nasty one, let me think a bit on how to fix this bug.

from liqp.

bkiers avatar bkiers commented on June 20, 2024

@mosabua could you try the fix in #47 ?

from liqp.

mosabua avatar mosabua commented on June 20, 2024

I can try it next week when I am back at work..

from liqp.

bkiers avatar bkiers commented on June 20, 2024

Great! 👍

from liqp.

mosabua avatar mosabua commented on June 20, 2024

I tested this now with the 0.6.8-SNAPSHOT from the PR branch and that works!

from liqp.

mosabua avatar mosabua commented on June 20, 2024

So from my perspective you can merge and release. Let me know if you need help with the release to the Central Repository..

from liqp.

bkiers avatar bkiers commented on June 20, 2024

I tested this now with the 0.6.8-SNAPSHOT from the PR branch and that works!

Cool, I'll tidy up that branch and add some more unit tests for nested contexts soon. I've been a bit busy lately.

So from my perspective you can merge and release. Let me know if you need help with the release to the Central Repository..

Jason has been doing releases to Maven Central. If you're okay with it, I can ask him to provide you access as well. Then I'll give you push access to this repo and you can do releases too. Just let me know.

from liqp.

mosabua avatar mosabua commented on June 20, 2024

I work with Jason so I will chat with him when I get a hold of him.

from liqp.

bkiers avatar bkiers commented on June 20, 2024

Cool 👍

from liqp.

bkiers avatar bkiers commented on June 20, 2024

Ok, the fix is in master and I've bumped the version. Feel free to release master to the Central Repository.

I also added you as a collaborator in case you want to change versions before future releases and/or merge develop into master before releases.

Thanks!

from liqp.

mosabua avatar mosabua commented on June 20, 2024

Great. I will just have to sort out the Central access.

from liqp.

mosabua avatar mosabua commented on June 20, 2024

Release done.

from liqp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.