Report unsupport tags/filters more nicely about liqp HOT 7 CLOSED

code to reproduce?

from liqp.

I'll make a test that has a template with a tag that has not been implemented and it should yield the error above. In my case it was happening as the template I was using made use of a post_url tag. Then that worked and it failed again on another tag.

Actually it tells you when a filter is missing, but I don't think the same happens with tags.

from liqp.

So at this location:

https://github.com/bkiers/Liqp/blob/master/src/main/java/liqp/parser/v4/NodeVisitor.java#L103

Placing something like this:

   String tagName = ctx.Id().getText();
    if (tags.containsKey(tagName)) {
      throw new RuntimeException("No tag exists: " + tagName);
    }

    return new TagNode(tags.get(tagName), expressions.toArray(new LNode[expressions.size()]));

Helped me report and find the tags that are missing. Maybe this isn't the ideal way to do this but something like this to help users determine if there are tags missing. I'm testing various Jekyll sites and there are a bunch of tags I'll have to implement so some better reporting would be good.

from liqp.

@msangel What's the recommend way to create templates with custom filters and tags?

from liqp.

from liqp.

I'll try and see if there is a test for registering a new tag and using it as this seems not to be working for me. I'll make a test quickly.

from liqp.

Thanks for the commit!

from liqp.