Red squares as icons again (more info) about skada-wotlk HOT 22 CLOSED

@wojas007 thanks a lot for reporting this.
This only happens with the threat module right? If yes, then I will have to rewrite the module completely or at least get rid of those icons because the threat API is a bit screwed.. If other modules collect data first everything works fine, if it's that module that starts collecting data about players .. you know the result.
I will put more work into it.

EDIT:
Specs aren't cached but rather got as segments start. Do you mean that changing spec to holy/disc/tank kept still showed their previous spec?

from skada-wotlk.

I actually didn't check if role icons were corrrect in other modules OR if threat module shows proper icons if they are other than roles.

from skada-wotlk.

Quick info:
I checked the data from yesterday (when bug occured) and checked role icons for other modules. They seem fine. Maybe threat module could somehow call for role info from somewhere else to put icons properly?

What I cannot check outside raid: when role icons are bugged for threat module, then what happens if I change them for spec/class icon. Will test it next time I play

from skada-wotlk.

I actually didn't check if role icons were corrrect in other modules OR if threat module shows proper icons if they are other than roles.

Pets didn't have "roles" assigned and it was my mistake. I added the missing lines to different files that assigns the role DAMAGER to them by default.

from skada-wotlk.

I actually didn't check if role icons were corrrect in other modules OR if threat module shows proper icons if they are other than roles.

Pets didn't have "roles" assigned and it was my mistake. I added the missing lines to different files that assigns the role DAMAGER to them by default.

Yeah I figured that could be the problem for pets.

However, druids (all specs) and priest (all specs) are different story. This doesn't happen always. but sometimes it does

from skada-wotlk.

I have a question @bkader

How specs and roles are assigned?

from skada-wotlk.

Using the LibGroupTalents-1.0 library.

from skada-wotlk.

Ok then it's too complicated for me to help here : P

But in general problem seems to lie in threat module

I have to check threat module if SPEC/CLASS icons are shown as icons

from skada-wotlk.

This little tweak seems to work for now but if we want a more complicated threat module just like Omen's I will have to rewrite it.

from skada-wotlk.

I don't really mind what these icons are. I only wanted to help get rid of red squares (unless this happens only for me) : p

from skada-wotlk.

@bkader I did some testing and here's what I found (maybe that helps):
Threat module doesn't track spec changes. Remember this issue?
#23

I logged my feral tank / feral dps druid and changed spec few times.
All the modules EXCEPT for the threat were able to assign proper icon (class, spec and role) after respec.
Only threat module was showing icons for spec/role that I logged in with.

EDIT:
So I tested this even more today during raid and here's what I know:

• Threat module does not check for spec change for sure
• Threat module has problems with ROLES: Shadow Priest (not sure about disci/holy) and Feral Druid (both tank and DPS)
• Threat module has problems with SPECS: Hunter MM, Priest Shadow, Druid Feral (both tank and DPS)
• Threat module seems to be working if CLASS as icon is selected

from skada-wotlk.

@wojas007 thanks for testing and providing this amount of info!
Tell me please, did you update the addon or not? Because I added the backup roles/specs in this commit

from skada-wotlk.

After update threat module still doesn't check for respec. Spec/roles don't change after you change spec. I'll check it again later today (solo).

I didn't check for squares yet because I didn't have a chance to raid.

EDIT:
So I made sure I had the newest versions of addon and:

1. As written above threat module doesn't check for respec.
2. Red squares don't appear SOLO. I still need raid to test it.

from skada-wotlk.

Hey @bkader !
Today I have a bit more info, because I had a chance to test newest version on raid. I need first to recall this:

What you wrote above is correct and sometimes happen. But this does NOT bother me, because it fixes itself for next fights.

However it does NOT fix itself for threat module. So if class/spec/role is "cached" wrongly for first encounter it will stay that way until relog/reload. So if red square appear in threat module for first fight you play, then it'll stay this way until relog. It is the same with respec - threat module won't update spec/role after changing spec.

But again - this is ONLY for threat module. Other modules work fine (even if loaded/cached wrongly, because they fix after time).

from skada-wotlk.

Hey @wojas007 and thanks again for the feedback.
Is there a chance you can edit the modules\Threat.lua file and change line 41 from Skada:find_player to Skada:get_player and give it a test?

from skada-wotlk.

I'll try it and let you know

from skada-wotlk.

I'll try it and let you know

@wojas007 , try this pastebin instead and let me know. If it works, it will be used instead.

from skada-wotlk.

Hey @bkader
I was only able to test this solo and still there's no response to changing spec.
Will check for red squares when I play any raid, but I think that it will be the same as for changing spec.

from skada-wotlk.

I'll try it and let you know

@wojas007 , try this pastebin instead and let me know. If it works, it will be used instead.

@bkader
I just tested this threat module. It seems that even if there are some red squares for first encounter, they fix for next fights.

However, there is still something wrong with spec AND role caching. For some reason threat module sometimes reads change of spec and sometimes it doesn't:

• The druid pointed with green rectangle changed to balance from tank (threat module shows proper spec)
• The druid pointed with red rectangle changed to feral DPS from resto (threat module shows wrong spec)

I really don't know if it's worth working on... If not just close the topic.
Also I still need some testing for red squares (for some reason they mostly appear in ruby sanctum for me)

from skada-wotlk.

@wojas007 thanks a lot for your tests and sorry for all the troubles you are having.
I completely removed specs from the Threat module and I allowed only class or role, just like any other addons.
If the problem with red squares still occurs, I will just remove roles and keep only classes.

from skada-wotlk.

@wojas007 thanks a lot for your tests and sorry for all the troubles you are having.
I completely removed specs from the Threat module and I allowed only class or role, just like any other addons.
If the problem with red squares still occurs, I will just remove roles and keep only classes.

@bkader remove roles then, because roles bug sometimes with respec. Keep only classes.

from skada-wotlk.

@bkader SOLO TESTS

after login

after changing spec:

from skada-wotlk.