Giter Club home page Giter Club logo

Comments (4)

bjw-s avatar bjw-s commented on August 19, 2024

The component should label should point to the identifier of the controller. So for the main controller it should always be main, and for any additional controller it would take the value of that controller.

The identifier won't get overwritten by the "presentation" name (which gets controlled by nameOverride)

Feel free to reopen if you still feel there's a bug somehow :)

from helm-charts.

runenielsen avatar runenielsen commented on August 19, 2024

Hi @bjw-s

Thanks a lot for your answer! It is good enough for me, if you have checked, that it works as intended - I am definitely not an expert in this 🙂

from helm-charts.

bjw-s avatar bjw-s commented on August 19, 2024

I added some additional unit tests, just in case ;)

from helm-charts.

runenielsen avatar runenielsen commented on August 19, 2024

@bjw-s : Thanks again, that is awesome! 💪

from helm-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.