Giter Club home page Giter Club logo

Comments (1)

bjornharrtell avatar bjornharrtell commented on September 23, 2024

Q: With scope leak, do you mean the first group of statements in javascript.util.js?

A: No javascript.util.js is another issue and I think it's the right way to do it i.e putting "javascript" in global scope is ok and compatible with the old lib. It also hides the browserify stuff from the lib user completely.

The global scope leakage is from the browserify code added to the built lib. "require" and "process" is leaked (and more?). I guess this is intentional by browserify to make CommonJS API available in the browser. I'd like to keep that completely hidden though, perhaps by simply enclosing the built lib with a private scope. This also means we should browserify javascript.util and jsts togheter when jsts is ready so that browserify stuff is only included once.

from javascript.util.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.