Giter Club home page Giter Club logo

Comments (4)

ManuelFeller avatar ManuelFeller commented on June 28, 2024

This trigger leads to Directus then no longer responding to requests, needing a restart of the CMS server. So for now this issue block proper usage of the extension

from directus-version-control-changelog.

ManuelFeller avatar ManuelFeller commented on June 28, 2024

The first thought seems to be wrong

  • the content is already available
  • the previous content of the field is not used at all

Further investigation on the affected system is needed

from directus-version-control-changelog.

ManuelFeller avatar ManuelFeller commented on June 28, 2024

Analysis of the code has shown that the error is happening at https://github.com/BIX-Digital/directus-version-control-changelog/blob/bugfix/split-on-undefined/src/core/ChangelogFormatter.ts#L17 -> is seems that userChangelog is undefined.

It is confirmed that neither the branch nor the file exist in the target repository yet, so this kind of makes sense.

from directus-version-control-changelog.

ManuelFeller avatar ManuelFeller commented on June 28, 2024

The actual culprit is https://github.com/BIX-Digital/directus-version-control-changelog/blob/bugfix/split-on-undefined/src/core/ChangelogWriter.ts#L102 -> in there it uses a hardcoded field name (changes) when looking for the changes content in event.payload.

This needs

  • to be mapped to the configured field name
  • more error tolerant access to that field (as in some setups changes may happen in fields that we're not interested in, not in the one where we expect them)

from directus-version-control-changelog.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.