Giter Club home page Giter Club logo

Comments (5)

bitshifter avatar bitshifter commented on August 27, 2024 1

Looking into this some more, I think part of the issue is negative values probably shouldn't be allowed with this function. Basically vector length cannot be less than zero, the clamp function makes sure then length is no less than the given min, but the doesn't really make sense if min (or max for that matter are negative. What should probably happen here is that the docs should say that min and max must be positive and we could add some glam_assets to check the inputs.

from glam-rs.

bitshifter avatar bitshifter commented on August 27, 2024

Thanks for the report, that definitely sounds wrong. I think I can see what the problem is in the implementation, I'll look at fixing that soon.

from glam-rs.

semihbkgr avatar semihbkgr commented on August 27, 2024

I've sent a draft PR for the f32 Vec2 method. If it looks good, I can update the other methods afterward.

from glam-rs.

semihbkgr avatar semihbkgr commented on August 27, 2024

I agree. It's much better

from glam-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.