Comments (5)
Looking into this some more, I think part of the issue is negative values probably shouldn't be allowed with this function. Basically vector length cannot be less than zero, the clamp
function makes sure then length is no less than the given min
, but the doesn't really make sense if min
(or max
for that matter are negative. What should probably happen here is that the docs should say that min and max must be positive and we could add some glam_assets
to check the inputs.
from glam-rs.
Thanks for the report, that definitely sounds wrong. I think I can see what the problem is in the implementation, I'll look at fixing that soon.
from glam-rs.
I've sent a draft PR for the f32 Vec2 method. If it looks good, I can update the other methods afterward.
from glam-rs.
I agree. It's much better
from glam-rs.
Related Issues (20)
- Feature request: add `towards` for vectors HOT 1
- Implement missing `From<Quat>` for matrices (get basis from quaternion) HOT 3
- From array for boolean vectors HOT 1
- Threshold for `is_normalized` seems wrong HOT 3
- Add `with_x `, `with_y`, to vector types HOT 1
- Add matrix transpose multiplication
- Vec2::fract() with negative numbers is inconsistent with f32::fract() HOT 5
- Quat::to_euler outputs bigger than PI * 2 at certain angles HOT 13
- Possible Incompleteness HOT 1
- Quat::from_euler truncates rotations to a single rotation HOT 2
- Multiply BVecN and VecN? Implement Into/From for BVecN to VecN with 1.0:s and 0.0:s HOT 1
- Quat / Euler tests fail on Apple Silicon HOT 11
- IVec2 and similar types should be Ord. HOT 1
- Extend `.normalize()` etc. to work for more values HOT 2
- Vec2/3's `angle_between` function is unclear/misleading HOT 16
- Mutable Swizzles HOT 3
- Inconsistent/missing scalar implementation of le/ge functions for Vec3A compared to sse2 HOT 2
- Any ambitions to implement static comma vectors? HOT 1
- impl From<Vec4> for Vec3A violates conversion is lossless contract
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glam-rs.