Giter Club home page Giter Club logo

Comments (10)

maraoz avatar maraoz commented on July 16, 2024

I'll look into it. Thanks for reporting

from bitcore.

maraoz avatar maraoz commented on July 16, 2024

I just created a test project which requires bitcore from npm and the Address example from README runs smoothly. I've heard from @ryanxcharles that others were having problems with BufferPut too. Can you tell us what OS and example you were running?

from bitcore.

SomeoneWeird avatar SomeoneWeird commented on July 16, 2024

@maraoz This is exactly why I said the npm module needs updating, there was a breaking bug fixed in master that made all the examples not work (bar the address one)

from bitcore.

maraoz avatar maraoz commented on July 16, 2024

I see. We're trying to get more people to have publish permissions to bitcore's npm so we accelerate this whole process. Thanks for your help!

from bitcore.

ryanxcharles avatar ryanxcharles commented on July 16, 2024

We just updated bitcore on npm, but if I read correctly, it is bufferput that is problematic. Correct? We'll need @gasteve to update npm for that.

from bitcore.

ryanxcharles avatar ryanxcharles commented on July 16, 2024

We have some version conflicts with bufferput. The version on BitPay GitHub is 0.1.1, but has code committed more recently than the 0.1.2 that is on npm. I suppose I could merge one into the other, update the version number, and then see if @gasteve can put that one on npm.

from bitcore.

ryanxcharles avatar ryanxcharles commented on July 16, 2024

Actually there are no differences in the index.js between the npm and bitpay github versions of bufferput, so there can't be any fixes in one that aren't in the other. If someone can figure out if there are any issues with the bitpay github bufferput, and issue a pull request that fixes it, then we can get the npm updated.

from bitcore.

SomeoneWeird avatar SomeoneWeird commented on July 16, 2024

784e4e3

from bitcore.

ryanxcharles avatar ryanxcharles commented on July 16, 2024

So, there's no problem then. FWIW I just tested the block monitoring example by installing bitcore fresh from npm and did not have any bufferput issues.

from bitcore.

SomeoneWeird avatar SomeoneWeird commented on July 16, 2024

Ah, I missed the bit where you said 'we just updated bitcore on npm' - my bad.

from bitcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.