Giter Club home page Giter Club logo

Comments (3)

micahriggan avatar micahriggan commented on June 13, 2024

The confirmations is a derived value from localChainTip.height-tx.height

I believe we may be doing that in insight.

from bitcore-node.

osagga avatar osagga commented on June 13, 2024

Yeah that's true, but I think it would be faster and more convenient if the tx API endpoint returns the confirmations.

If the API user needs to derive the confirmations, the user will need to make two API calls per transaction (one to get the current chain tip, and another to get the tx.height) to calculate the confirmations, instead of only one if the API provides it.

All the node has to do is to locally compute the confirmations when a transaction is requested by the API (or multiple transactions.) Hence, not increasing the storage, but slightly impacting the response time (not by a lot compared to the user making two API calls to compute the same value).

from bitcore-node.

osagga avatar osagga commented on June 13, 2024

Fixed, check bitpay/bitcore#1692

from bitcore-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.