Giter Club home page Giter Club logo

Comments (6)

kashikoibumi avatar kashikoibumi commented on June 19, 2024

I found that this problem had been fixed in 'Porting bitmessageqt to Qt5 #1389', but it is not merged to v0.6 .

from pybitmessage.

kashikoibumi avatar kashikoibumi commented on June 19, 2024

Truth is a bit different.
The problem that arg() cannot be used is a problem on PyQt version differences, not in Python version differences.
PyQt4's translate() supports arg(), but PyQt5's doesn't.

Example programs follows:

$ cat qt4translate.py 
from PyQt4 import QtGui
print(QtGui.QApplication.translate("default", "hello %1").arg("world"))

$ python2 qt4translate.py 
hello world

$ cat qt5translate.py 
from PyQt5 import QtWidgets
print(QtWidgets.QApplication.translate("default", "hello %1").arg("world"))

$ python2 qt5translate.py 
Traceback (most recent call last):
  File "qt5translate.py", line 2, in <module>
    print(QtWidgets.QApplication.translate("default", "hello %1").arg("world"))
AttributeError: 'unicode' object has no attribute 'arg'

$ cat qtpytranslate.py 
from qtpy import QtWidgets
print(QtWidgets.QApplication.translate("default", "hello %1").arg("world"))

$ python2 qtpytranslate.py 
Traceback (most recent call last):
  File "qtpytranslate.py", line 2, in <module>
    print(QtWidgets.QApplication.translate("default", "hello %1").arg("world"))
AttributeError: 'unicode' object has no attribute 'arg'

from pybitmessage.

kashikoibumi avatar kashikoibumi commented on June 19, 2024

Simply replacing arg() to format() works well with PyQt5, but it does not work with PyQt4.

$ cat qt5translate-format.py 
from PyQt5 import QtWidgets
print(QtWidgets.QApplication.translate("default", "hello {0}").format("world"))

$ python2 qt5translate-format.py 
hello world

$ cat qt4translate-format.py 
from PyQt4 import QtGui
print(QtGui.QApplication.translate("default", "hello {0}").format("world"))

$ python2 qt4translate-format.py 
Traceback (most recent call last):
  File "qt4translate-format.py", line 2, in <module>
    print(QtGui.QApplication.translate("default", "hello {0}").format("world"))
AttributeError: 'QString' object has no attribute 'format'

So in order to work with both PyQt5 and PyQt4, additional wrapping by str() is required.

$ cat qt5translate-format-str.py
from PyQt5 import QtWidgets
print(str(QtWidgets.QApplication.translate("default", "hello {0}")).format("world"))

$ python2 qt5translate-format-str.py
hello world

$ cat qt4translate-format-str.py 
from PyQt4 import QtGui
print(str(QtGui.QApplication.translate("default", "hello {0}")).format("world"))

$ python2 qt4translate-format-str.py 
hello world

This also works well with Python3.

$ python3 qt5translate-format-str.py
hello world

$ python3 qt4translate-format-str.py
hello world

The problem is that code becomes complex.
Perhaps it is better to modify the shortcut function _translate() internally apply str().

from pybitmessage.

PeterSurda avatar PeterSurda commented on June 19, 2024

arg is needed for the grammar to work correctly. You don't have this issue in Japanese, but you can see it in English, e.g. "1 connection", "2 connections". In other languages it may be even more complex.

from pybitmessage.

kashikoibumi avatar kashikoibumi commented on June 19, 2024

I did not noticed it at all!!
Sorry, I don't understand it fully yet, I will investigate it more deeply.

from pybitmessage.

kashikoibumi avatar kashikoibumi commented on June 19, 2024

As far as my additional research, QString's arg() is able to be used in only Python2 + PyQt4.
In configurations including Python3 or PyQt5, QString is mapped on Python's native string types (unicode in Python2, str in Python3), and they do not have arg() method.
So if you are going to step forward to Python3 or PyQt5, it is required to drop arg() and use format() instead.

There is no solution that respects compatibility among Python versions nor PyQt versions.

Then, what we should do?

from pybitmessage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.