Giter Club home page Giter Club logo

Comments (4)

mgdigital avatar mgdigital commented on May 19, 2024

Hi, it seems that pressing enter in the search box doesn't trigger the usual keyup event on iOS.

In general, the app has not been designed for or tested on mobile at all (because most people will be using it on desktop alongside their desktop BitTorrent client). Better mobile support is a medium-term goal but not the highest priority right now so I'll leave this open for the time being.

from bitmagnet.

josteink avatar josteink commented on May 19, 2024

While its obvious Bitmagnet is not yet designed/optimized for mobile use, this particular bug means it's not actually usable at all.

Like literally cannot use it. Because you will never be able to ... search for anything.

This could probably be fixed very easily by also handling the blur-event on the input-field, and not just responding to enter.

It might be as easy duplicating these lines:

(keyup.enter)="
search.setQueryString(queryString.value ?? '');
search.firstPage();
search.loadResult()

And adding this:

            (blur)="
              search.setQueryString(queryString.value ?? '');
              search.firstPage();
              search.loadResult()

from bitmagnet.

josteink avatar josteink commented on May 19, 2024

Another workaround could be to make the refresh button always consider the input-field before issuing the network request.

These should be fairly small changes in code which would make a very big impact (not usable at all on iphones => actually usable).

from bitmagnet.

josteink avatar josteink commented on May 19, 2024

I've provided a very simplistic workaround for this in the following PR: #235

Tested locally on iPhone and works correctly as far as I see. Review, pretty please?

Also: Happy easter!

from bitmagnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.