"accumulates inputs until the target value is matched" about coinselect HOT 9 CLOSED

I think what’s confusing is the term ‘matched’. If input == (matches) output then fee = 0. Do you mean ‘reached’?

Don’t get me wrong, cs works great in my app. No issues with it.

from coinselect.

I'm confusing myself. Of course, 'matched' is the correct term for Blackjack (like the game), not reached.

What I should have focussed on was the term 'target value'. This refers to the output + pre-calculated fee, is that right?

var fee = feeRate * (bytesAccum + inputBytes)

Whereas I was reading 'target value' == THE output value, as in

let targets = [{ address: payToAddr, value: amount }]

from coinselect.

From the inputs?

fee = input - output, where input >= output.

If you have 3 unspents (90 + 50 + 25), and 1 output (100), and you do a basic accumulative strategy, you'll probably end up with 2 inputs (90 + 50) and 1 output (100), with fee (40).

I'll update the README example to be copy-pastable.

from coinselect.

Yes, reached.

PR accepted.

from coinselect.

It does say reached
https://github.com/bitcoinjs/coinselect/blame/11e0e925ccc939c2b0889b43020a590e89a66b20/README.md#L15

If you are referring to blackjack:

Then, it is matched.

Where target value is outAccum + fee.

from coinselect.

What I should have focussed on was the term 'target value'. This refers to the output + pre-calculated fee, is that right?

Yes, the "target value" refers to outAccum + fee, and is variable in that it increases as the fee increases (as inputs are added).

from coinselect.

Do you have another suggestion for the term?

You are right in that it is ambiguous and could be better.

from coinselect.

I think 'target value' is fine if referring to the actual amount you want the target address to receive and fits with the terms already used when constructing the 'targets' array. I would only add '+ fees' and leave it for people to read the code to see how the fees are dynamically determined and included.

from coinselect.

See #35

from coinselect.