Giter Club home page Giter Club logo

Comments (9)

nilshempelmann avatar nilshempelmann commented on June 19, 2024

indices filename contains wrong frequency.
an indice calculated with frq='YS' should have _yr_ in the filename but finch keeps the original _day_.
related to:
#80
Ouranosinc/xclim#368

from finch.

nilshempelmann avatar nilshempelmann commented on June 19, 2024

driving model is repeated in filename:
_MPI-M-MPI-ESM-MRMPI-M-MPI-ESM-MR_

from finch.

nilshempelmann avatar nilshempelmann commented on June 19, 2024

rename indice file tg_mean to tg-mean. underscore is the seperator of the DRS elements

from finch.

davidcaron avatar davidcaron commented on June 19, 2024

driving model is repeated in filename:
MPI-M-MPI-ESM-MRMPI-M-MPI-ESM-MR

Could you help me recreate this? I'm not sure in which case this can happen.

from finch.

nilshempelmann avatar nilshempelmann commented on June 19, 2024

It happened while calculating the indices:
In [44], In [45]. but its overwritten meanwhile.
https://github.com/nilshempelmann/NAP_Niger/blob/master/indices_calculation.ipynb

from finch.

davidcaron avatar davidcaron commented on June 19, 2024

I'm not sure how it could do this in finch... unless I'm missing something, the only remaining way I see for this to happen is if this string is inside the source dataset's driving_model_id.

from finch.

nilshempelmann avatar nilshempelmann commented on June 19, 2024

it repeated the RCM as well:
e.g.:
prcptot_AFR-22_MPI-M-MPI-ESM-MRMPI-M-MPI-ESM-MR_historical_r1i1p1_ICTP-RegCM4-7-0ICTP-RegCM4-7_v0_day_19700101-20050101.nc

you are right: its an error of the file:
:driving_model_id = "MPI-M-MPI-ESM-MRMPI-M-MPI-ESM-MR"
:model_id = "ICTP-RegCM4-7-0ICTP-RegCM4-7"
made by: :contact = "Canadian Centre for Climate Services"

I ll check the other files where it happened and send you per mail.

from finch.

nilshempelmann avatar nilshempelmann commented on June 19, 2024

not receiving the DRS names for CMIP6 file outputs

data/indices/out.nc.
data/indices/out-1.nc.
data/indices/out-2.nc.
data/indices/out-3.nc.
data/indices/out-4.nc.
data/indices/out-5.nc.

from finch.

aulemahal avatar aulemahal commented on June 19, 2024

There are specific cases for CORDEX, EOBS and CMIP5. All other cases (including CMIP6), should be covered by

else:
params = [
variable,
ds.attrs.get("frequency"),
ds.attrs.get("model_id"),
ds.attrs.get("driving_model_id"),
ds.attrs.get("experiment_id", "").replace(",", "+"),
ds.attrs.get("driving_experiment_id", "").replace(",", "+"),
]
params = [k for k in params if k]
filename = "_".join(params)

But the filename defaults to out if there was an error. I think what is missing here is a warning about why an error was encountered.

from finch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.