Giter Club home page Giter Club logo

Comments (7)

yoelcortes avatar yoelcortes commented on July 25, 2024

Sounds good, the proposed feature is pretty much how we would get it done in BioSTEAM.

As for Spearman correlation, I'll expose the <Model>.table attribute so that people can do things like:

model.table = model.table.dropna()

Pandas has some excellent methods for data cleaning, so I think leaving this up to the user would be better than adding more optional behaviors that may slow down methods in biosteam.

Thanks!

from biosteam.

yalinli2 avatar yalinli2 commented on July 25, 2024

Sounds good and I agree on letting users clean up the data! I'll leave this issue open until we have the clear_cache function in BioSTEAM, but you can close it now if you have it on a separate TODO list, thanks!

from biosteam.

yoelcortes avatar yoelcortes commented on July 25, 2024

I made a couple of updates to the repository:

  1. Added a reset_cache method to unit operations and system objects.
  2. <Model>.table attribute can now be set.
  3. Model spearman method can now take parameters. So <Model>.spearman(metrics=None) is now <Model>.spearman(parameters=None, metrics=None)... You might get a bug due to the change in signatures.
  4. The spearman table uses multiindices just like the <Model>.table attribute. We can now do things like:
>>> rhos = model.spearman(parameters, metrics)
>>> rhos[metrics[0].index] # -> metric rhos for all parameters
>>> rhos.loc[parameters[0].index] # -> parameter rhos for all metrics

Could you test it out for any bugs? Once its tested, I'll make upload it to PyPI.

Thanks!

from biosteam.

yalinli2 avatar yalinli2 commented on July 25, 2024

from biosteam.

yalinli2 avatar yalinli2 commented on July 25, 2024

Errr I think you forgot to ask the system to re-simulate after clearing the cache? Otherwise it works fine!

from biosteam.

yoelcortes avatar yoelcortes commented on July 25, 2024

Gotcha, just fixed that, can you test again? Thanks!

from biosteam.

yalinli2 avatar yalinli2 commented on July 25, 2024

All works well! Thanks for updating this so quickly!

from biosteam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.