Giter Club home page Giter Club logo

Comments (15)

BioPhoton avatar BioPhoton commented on June 3, 2024 2

Hi @mhjmaas !
BIG THX for your help!

Enjoy AOT in version 3.0.0 on npm

:-)

from angular-star-rating.

BioPhoton avatar BioPhoton commented on June 3, 2024 1

Hy!

Atw I have no clue why... Will have a look later this week.

from angular-star-rating.

mhjmaas avatar mhjmaas commented on June 3, 2024 1

It seems you need to modify line 52 in the angular-star-rating sourcecode:

star-rating.component.ts

from:

(mouseleave)="onStarHover()"> to (mouseleave)="onStarHover($event)">

AOT compilation needs to match these parameters exactly to be able to do efficient tree shaking I believe. At least when I edit this line, everything starts working fine again. :)

from angular-star-rating.

JustinSchneider avatar JustinSchneider commented on June 3, 2024

Hey, @BioPhoton. Any luck with finding a cause of this?

from angular-star-rating.

BioPhoton avatar BioPhoton commented on June 3, 2024

Hi!

Sry, currently no time... For me it looks like a typing Problem. Did you run lint? What does linting say?

from angular-star-rating.

eyalhakim avatar eyalhakim commented on June 3, 2024

I'm running into the same problem, would love to know if any of you finds the solution.
My lint doesn't show any errors btw.

from angular-star-rating.

BioPhoton avatar BioPhoton commented on June 3, 2024

Do you Guys use the ts Files or the Compiler js Files?

from angular-star-rating.

JustinSchneider avatar JustinSchneider commented on June 3, 2024

@BioPhoton I'm not sure how to answer that. It's an angular-cli project (using webpack, but indirectly). Locally I run 'ng serve' (JIT), while our build server does AOT, and that's where the problem shows up. I can replicate this by running our 'ng build -prod' command locally, but beyond that I can't really say.

Still learning a lot of this stuff, unfortunately.

from angular-star-rating.

BioPhoton avatar BioPhoton commented on June 3, 2024

Hi! Very fast reply!!! 😎

So how do you Import the lib?

Please Show me the Line of Code... The Import Statement or so...

THX!

from angular-star-rating.

JustinSchneider avatar JustinSchneider commented on June 3, 2024

In app.module.ts:
import { StarRatingModule } from 'angular-star-rating'; @NgModule({ declarations: [ ... ], imports: [ StarRatingModule ] })

And then in my component:
<star-rating-comp [starType]="'svg'" [numOfStars]="10" [size]="'large'"> </star-rating-comp>

Is that what you needed?

from angular-star-rating.

BioPhoton avatar BioPhoton commented on June 3, 2024

Yes! Just want to make shure that u use the ts Files.. have to try something. Im back home in 3h I guess....

Just for interest, could you try to Reference the ts Files directly? I guess it's angular-star-rating/src/...module

from angular-star-rating.

eyalhakim avatar eyalhakim commented on June 3, 2024

@BioPhoton tried it now, same result :/

from angular-star-rating.

BioPhoton avatar BioPhoton commented on June 3, 2024

Thx for trying. Have to look this up!

Best,
Michael

from angular-star-rating.

eyalhakim avatar eyalhakim commented on June 3, 2024

No problem!

Would really appreciate it if you could get to it soon.
It would be a great deal of help!

Thank you

from angular-star-rating.

eyalhakim avatar eyalhakim commented on June 3, 2024

Thank you both!

from angular-star-rating.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.