Function viz_gb_on_period not found about baseballr HOT 6 CLOSED

Yes, it’s a case issue

from baseballr.

I changed this in the R file. It was trying to export viz_gb_on_period, but the function was viz_GB_on_period. Try a reinstall and let me know if it works.

from baseballr.

Hello @BillPetti,

Thanks for the feedback. I tried now and that problem is solved. Nevertheless, there is still an issue when trying to run it. It seems that it's not allowing separate function from "dplyr" to run.

from baseballr.

I looked this over, a few things:

• it looks like separate is from tidyr, not dplyr
• you aren't importing the function, which you should (i.e. @importFrom tidyr separate)
• I would also default to naming the package explicitly just to make sure you don't run into any issues with multiple functions having the same name (i.e. tidyr::separate)

Can you fix this and then resubmit as a pull request?

from baseballr.

@darh78 is this something you were going to fix and resubmit a pull request for?

from baseballr.

@BillPetti sure!
I just hadn’t the time. I’ll try it this month.
Regards

from baseballr.