Giter Club home page Giter Club logo

Comments (7)

flxzt avatar flxzt commented on June 15, 2024 1

Please don't get rid of the rebuild / run separation. Sometimes its just convenient to rerun the app to check something even when some files are already modified.

from flatpak-vscode.

SeaDve avatar SeaDve commented on June 15, 2024 1

I see, that makes sense.

Since the "run" button used in #55 is mapped to rebuild command, it would make sense to rename it to just run and rename run command to run-without-rebuild or something. Mainly for coherency, and to convey semantic opposite of stop.

from flatpak-vscode.

bilelmoussaoui avatar bilelmoussaoui commented on June 15, 2024

The reason I kept the two steps separate is we don't have a way to track the sources files if there were any changes and you would probably end up waiting a couple of seconds before the app is launched which could be not great :/

from flatpak-vscode.

SeaDve avatar SeaDve commented on June 15, 2024

there's probably a vscode api to track modified file

from flatpak-vscode.

bilelmoussaoui avatar bilelmoussaoui commented on June 15, 2024

The issue is to figure out if those files are part of the source code. That is something normally the build system can know

from flatpak-vscode.

bilelmoussaoui avatar bilelmoussaoui commented on June 15, 2024

I think we can drop rebuild and only keep build here. We know whether the app was built once or not, so we can just make "build" triggers a "rebuild" instead. Make the run button triggers both build & run, and the run command from the palette only triggers run.

from flatpak-vscode.

SeaDve avatar SeaDve commented on June 15, 2024

I think we want to have the run button to have the same behavior as the command palette one (for coherence), or to atleast have that behavior as an entry in the command palette

Edit: Sorry, I misunderstood it when I first read it. I think that's a good idea. We also probably need though a command palette entry that does the same as the run button (Something like build-and-run)

from flatpak-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.