Giter Club home page Giter Club logo

Comments (6)

 avatar commented on August 17, 2024

I can't reproduce this. Setting a widget to both a custom playlist and a skin-provided playlist sets the widget and widgetTarget properties as expected.

from script.skinshortcuts.

Nessus85100 avatar Nessus85100 commented on August 17, 2024

Turns out that the widgetTarget property it's empty only for playlists defined in overrides.xml. I have a separate node in my overrides.xml file in where i have included the default playlists (<content>playlist-video</content>) plus some extra provided by the skin. This is how my playlist node looks with one of the extra playlists and the defaults ones :

<node label="136">
  <node label="32004">
    <shortcut label="31245" type="32004" widget="::PLAYLIST::" icon="DefaultVideoPlaylists.png" widgetType="tvshows" condition="Library.HasContent(tvshows)">special://skin/extras/playlists/KidsTVShows.xsp</shortcut>
    <content>playlist-video</content>
  </node>
  <node label="32005">
    <content>playlist-audio</content>
  </node>
</node>

For every playlist that is defined like this here (eg "KidsTVShows.xsp") the widgetTarget property it's empty. Those that are provided by the <content>playlist-video</content> the widgetTarget property is set fine.

Thanks
Nessus

from script.skinshortcuts.

 avatar commented on August 17, 2024

That's because you need to define widgetTarget in these cases - see wip docs here https://github.com/Ignoble61/script.skinshortcuts/blob/documentation/resources/docs/advanced/Custom%20groupings.md for details of the <shortcut /> element.

(And it looks like the widget property is getting set to the widget element in your <shortcut /> element - which is intended but I actually thought was broken....)

from script.skinshortcuts.

Nessus85100 avatar Nessus85100 commented on August 17, 2024

Aha... didn't know that. So far all my other widgets are playable items or the onclick action is handled by the skin or by a script.

(And it looks like the widget property is getting set to the widget element in your element - which is intended but I actually thought was broken....)

Yea it works fine. By the way can you think of any reason why i have set the widget property like that (::PLAYLIST::) and not like as simple string (Playlist) ?.... lol i know that is stupid to ask YOU about that but i am afraid that if i did that for reason and is not some c/p thing will cause other problems.

from script.skinshortcuts.

 avatar commented on August 17, 2024

It shouldn't cause any issues as far as I can tell. I'm not in a position to be able to double-check in the code, but I think the widget attribute is literally only set as the widget property - nothing should change in how that shortcut is processed no matter what the widget attribute is set to.

from script.skinshortcuts.

Nessus85100 avatar Nessus85100 commented on August 17, 2024

Ok, thanks a lot for the info.

Cheers
Nessus

from script.skinshortcuts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.