Giter Club home page Giter Club logo

Comments (6)

heuermh avatar heuermh commented on August 24, 2024

@fnothaft @jpdna I believe this one is a blocker for the next point release (0.10.1 or 0.11.0, however we decide) as I can't finish the implementation in bigdatagenomics/adam#1288 without a decision on this.

from bdg-formats.

jpdna avatar jpdna commented on August 24, 2024

Add new reference value fields

I like the approach in your 6. above of adding new explicitly named ref prefixed fields.
If the decision was made to do that, then what further problems still remain?

from bdg-formats.

heuermh avatar heuermh commented on August 24, 2024

Option 6 only helps for the specific case of Number=R VCF INFO attribute values that map to fields. We'd still need something for generic Number=R VCF INFO values in VariantAnnotation.attributes (1-4).

Then after many years dealing with corporate DBAs and other such naming standard b.s., I no longer abbreviate in field, method, or class names, so it'd be reference*. :)

from bdg-formats.

jpdna avatar jpdna commented on August 24, 2024

How about we have a rule that for all Number=R attribute map "fields" that the the String that is the the value must itself by a comma delimited list with exactly two fields (post splitting), ref and alt

from bdg-formats.

heuermh avatar heuermh commented on August 24, 2024

I'd go for that if we also went with option 5 for AD,ADF,ADR. Added to description above.

from bdg-formats.

jpdna avatar jpdna commented on August 24, 2024

Yeah I see why you'd want option 5 over 6 then for consistency, that's be fine with me.

We could also make attributes a map of array where often the array would be length one (rather than have comma delimited strings in some cases), but I am not sure if I like the potential overhead of that nesting. Anyway, that attributes map representation decision would be easy to change in future though if we changed mind.

from bdg-formats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.