Comments (11)
@surbas any thoughts on this? I think this might have been introduced as a result of your work.
from bigcommerce-api-python.
from bigcommerce-api-python.
Just because of the changeset between the two versions - 0.17.3 works fine, and 0.18.0 is broken. Majority of the commits between the two are yours :)
from bigcommerce-api-python.
@bookernath I took a look at the blame for the oauth_fetch_token
and fetch_token
methods that are throwing the ClientRequestException
. The code for either has not change in 3 to 4 years and hence has nothing to do with the iteradd
work that I did. Since I was already here... I took a deeper dive It seems like this is your server throwing an error. My gut tells me from looking at these functions that fault lies either on the input or the server. The code in question is doing a simple POST with very little handling of the inputs as far as I can tell.
from bigcommerce-api-python.
@surbas I narrowed the issue down to the changes to connection.py in this commit: a9d9ba0
I think it's related to some of the refactoring; the OAuth token POST request uses the same methods as other API requests, and a lot of the underpinnings of that (fetch_token --> post --> run_method) are touched by your changes here.
Still digging into it...
from bigcommerce-api-python.
@bookernath What are the steps to reproduce the reported bug to narrow down issue? Happy to write test and fix.
from bigcommerce-api-python.
@surbas thanks for the follow-up!
- Install 0.18.0 or install the exact commit I mentioned
- Create a draft app (you can use https://github.com/bigcommerce/hello-world-app-python-flask on heroku easily)
- Try to install the app, get a 406 error as above
- If you switch your version to 0.18.1 or 0.17.3 this does not happen
from bigcommerce-api-python.
@bookernath i just tried to deploy to heroku and got the following error: This is using the button on your link.
Traceback (most recent call last):
File "", line 1, in
File "/app/app.py", line 4, in
from flask_sqlalchemy import SQLAlchemy
ModuleNotFoundError: No module named 'flask_sqlalchemy'
from bigcommerce-api-python.
@surbas I've updated the requirements.txt and it works now. Nice catch!
from bigcommerce-api-python.
@bookernath switched to local. I can hit /instructions.html. When you say "install the app" you talking about heroku (which i was assuming) or on big commerce?
from bigcommerce-api-python.
@surbas I mean to attempt the app installation flow by installing the draft app in your BC control panel.
To do this, you'll need to follow the full set of instructions and have a draft app created in BC. The error only occurs when the app is being installed, which is when the OAuth token exchange happens.
from bigcommerce-api-python.
Related Issues (20)
- Zip payment method not returning in API
- Using v3 Catalog/Product filters HOT 2
- Go SDK + CloudQuery Source Plugin
- I can't get the addresses when I do an api.Customer.all()
- Rate Limit only firing once
- api.Products.count() doesn't work anymore? HOT 2
- api.ProductCustomFields.get(productidnumber,fieldidnumber).delete does not delete custom field HOT 1
- Odoo Connector
- ProductVideos cannot create, delete, or delete_all HOT 2
- Unset Price Value On Product Variations HOT 1
- Filter Keyword in API returns only exact match and not partial match
- Order field "custom_status" update returns an error HOT 2
- Seems to be no end point for Blog Tags
- 429 error shouldn't appear should it?
- Order status .iterall() infinite loop
- Updating customer password gives random 400 errors HOT 5
- Is there a way to update products in batches (more than 1 at a time)? HOT 1
- Old releases, broken functions, V3 support HOT 1
- Getting subresources alongside products (not separately) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bigcommerce-api-python.