Giter Club home page Giter Club logo

Comments (11)

bookernath avatar bookernath commented on July 17, 2024

@surbas any thoughts on this? I think this might have been introduced as a result of your work.

from bigcommerce-api-python.

surbas avatar surbas commented on July 17, 2024

from bigcommerce-api-python.

bookernath avatar bookernath commented on July 17, 2024

Just because of the changeset between the two versions - 0.17.3 works fine, and 0.18.0 is broken. Majority of the commits between the two are yours :)

from bigcommerce-api-python.

surbas avatar surbas commented on July 17, 2024

@bookernath I took a look at the blame for the oauth_fetch_token and fetch_token methods that are throwing the ClientRequestException. The code for either has not change in 3 to 4 years and hence has nothing to do with the iteradd work that I did. Since I was already here... I took a deeper dive It seems like this is your server throwing an error. My gut tells me from looking at these functions that fault lies either on the input or the server. The code in question is doing a simple POST with very little handling of the inputs as far as I can tell.

from bigcommerce-api-python.

bookernath avatar bookernath commented on July 17, 2024

@surbas I narrowed the issue down to the changes to connection.py in this commit: a9d9ba0

I think it's related to some of the refactoring; the OAuth token POST request uses the same methods as other API requests, and a lot of the underpinnings of that (fetch_token --> post --> run_method) are touched by your changes here.

Still digging into it...

from bigcommerce-api-python.

surbas avatar surbas commented on July 17, 2024

@bookernath What are the steps to reproduce the reported bug to narrow down issue? Happy to write test and fix.

from bigcommerce-api-python.

bookernath avatar bookernath commented on July 17, 2024

@surbas thanks for the follow-up!

from bigcommerce-api-python.

surbas avatar surbas commented on July 17, 2024

@bookernath i just tried to deploy to heroku and got the following error: This is using the button on your link.

Traceback (most recent call last):
File "", line 1, in
File "/app/app.py", line 4, in
from flask_sqlalchemy import SQLAlchemy
ModuleNotFoundError: No module named 'flask_sqlalchemy'

from bigcommerce-api-python.

bookernath avatar bookernath commented on July 17, 2024

@surbas I've updated the requirements.txt and it works now. Nice catch!

from bigcommerce-api-python.

surbas avatar surbas commented on July 17, 2024

@bookernath switched to local. I can hit /instructions.html. When you say "install the app" you talking about heroku (which i was assuming) or on big commerce?

from bigcommerce-api-python.

bookernath avatar bookernath commented on July 17, 2024

@surbas I mean to attempt the app installation flow by installing the draft app in your BC control panel.

To do this, you'll need to follow the full set of instructions and have a draft app created in BC. The error only occurs when the app is being installed, which is when the OAuth token exchange happens.

from bigcommerce-api-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.