Comments (15)
@bhovhannes - I'm afraid everyone has gotten ahead of themselves. A few things right out of the gate.
- This needs to be discussed by the webpack-contrib owners.
- There are legal considerations as we are a part of the JavaScript Foundation.
- We do not nor will we ever use Greenkeeper in contrib.
- This discussion will be moved over to https://github.com/webpack-contrib/organization/issues where it should have been to begin with.
- The idea in whatever final form will be discussed and if it makes sense for both groups wither myself or @bebraw will get in touch.
from svg-url-loader.
In general I am ok with that. However we should discuss the details. Where is the correct place for such discussion?
from svg-url-loader.
@bhovhannes good news!
from svg-url-loader.
@evilebottnawi, can you send me an invite for webpack slack team? I think I need it to sign in...
from svg-url-loader.
@bhovhannes oh sorry, gave the wrong link https://webpack.slack.com/messages/C1LUX2DS9/ 😄 or we can discussion
about this here, if you are comfortable
from svg-url-loader.
@evilebottnawi I cannot sign in to webpack team on slack, because I don't have an account there. So, let's speak here. Please bring in any people from webpack/webpack-contrib
you feel it will be nice to participate in discussion.
Here is how I see the current differences between svg-url-loader and url-loader.
- My plan for
svg-url-loader
is to add option to minimize imported SVGs using SVGO. svg-url-loader
has tests, which run on Travis automatically.svg-url-loader
repo is greenkeeper enabled.
Regarding 1.
That can be implemented in a separate loader and these 2 loaders may work in tandem, but minimizing is so common task that I think it will be better to have it built-in in the svg-url-loader
.
I am not sure if minimizing SVGs is something url-loader
should do.
Regarding 2.
Tests should be added to url-loader
as well. Only after testing infrastructure will be ready we can start merge of svg-url-loader
.
Regarding 3.
I cannot enable greenkeeper on url-loader
, as I am not an admin of webpack/webpack-contrib
. I will miss its PRs.
I think separate issues should be opened for each of mentioned points in url-loader
repo in order to proceed effectively. @evilebottnawi, what do you think?
from svg-url-loader.
My plan for
svg-url-loader
is to add option to minimize imported SVGs using SVGO.
Sounds good, each loader can works in minify
mode. But url-loader
handle not only svg
and maybe it is be related to compress/compress-images/image/imagemin-loader
. This would keep the compression options (for imagemin
) in one place, but we can think about this more and we can will find to a common decision. Now we can https://github.com/Klathmon/imagemin-webpack-plugin
(not good solution because for this purpose best be loader
, but some plugins, example CopyWebpackPlugin
can copying image also, svg
also, this will be a small overload if svg-url/url-loader
will do it) and https://github.com/tcoopman/image-webpack-loader
(It seems to be outdated and have weird name, best for me imagemin/compress-image-loader
- this loader
don't load images, just compress), i have own solution https://github.com/itgalaxy/imagemin-webpack (have loader and plugin for both purposes).
svg-url-loader
has tests, which run on Travis automatically.
No problems, in many our loader exists test and they run on travis
automatically. And we should to write tests for him, we just sometimes do not have time for all this 😭
svg-url-loader
repo is greenkeeper enabled.
greenkeeper
in now not very smart
bot, sub bad true
, but i'm sure that this will not be a problem, perhaps this will be the beginning to correct his behavior and enable (enable again in some repo 😄 )
from svg-url-loader.
- My plan for svg-url-loader is to add option to minimize imported SVGs using SVGO.
This would be better as a separate loader chained with url-loader
then 😛
svg-url-loader
has tests, which run on Travis automatically
WIP
svg-url-loader
repo is greenkeeper enabled
We handle all majot deps in webpack-contrib (loader-utils
, schema-utils
(Options Validation)) && are actively maintaining the 'core' loaders
Long story short, we could add an encoding
option to url-loader
and optimisations (generic or webpack related) like this loader currently does with the content
replacement part could be done aswell depending on the MIME type
The reason for this is mainly to avoid the already existing UX problems many folks have with webpack today, since picking the right loader/plugin
is hard (especially for beginners). Some unification effort would be highly appreciated.
from svg-url-loader.
- My plan for svg-url-loader is to add option to minimize imported SVGs using SVGO.
There is svgo-loader which seems to does exactly what I was intended to do here, so that point is not so important at this moment.
- svg-url-loader has tests, which run on Travis automatically
Can Travis CI be enabled on url-loader? What can I do from my side to help with that?
- svg-url-loader repo is greenkeeper enabled
Can you (or someone else) enable greenkeeper on url-loader
repo? What can I do from my side to help with that?
Long story short, we could add an encoding option to url-loader and optimisations (generic or webpack related) like this loader currently does with the contentreplacement part could be done aswell depending on the MIME type
What can I do from my side? Should I put together a PR which will bring in the functionality to url-loader
?
from svg-url-loader.
@bhovhannes Yep, PR is be good decision. Let's do PR 👍
Can Travis CI be enabled on url-loader? What can I do from my side to help with that?
Also do in PR.
Can you (or someone else) enable greenkeeper on url-loader repo? What can I do from my side to help with that?
In discussion into PR we can find solution for this, maybe not a bad idea to enable greenkeeper
for this repo and see how correctly their now works.
from svg-url-loader.
@bhovhannes You can do this step-by-step:
- Add functionality.
- Add tests.
- Enable greenkeeper.
- ...
- PROFIT!
- Your one of main contributor
url-loader
😄
from svg-url-loader.
Close issue here, if someone want this union please recreate issue here https://github.com/webpack-contrib/organization, thanks for everyone!
from svg-url-loader.
/cc @bhovhannes still interesting with union url-loader
?
from svg-url-loader.
@evilebottnawi after the last comment of @d3viant0ne whole process seems unnecessarily complicated to me.
At this moment I have little time to dedicate to open-source, and if I will I'd better spend it to address some long standing issues here.
So, speaking shortly, no.
from svg-url-loader.
@bhovhannes we implement decoder
option for url-loader
so all what you do loader now possible do with url-loader
, so i think you can be champion of decoder.
from svg-url-loader.
Related Issues (20)
- How to use this in html? HOT 2
- Images svg aren't loading, how to fix? HOT 2
- Incorrectly escapes # in style-element HOT 3
- Question: is there a way to disable plugin inline for few SVG? HOT 1
- Update README to include webpack options configuration for supported parameters HOT 2
- problem with `file-loader` and deps HOT 15
- The benefits of data:xyz style vs. SVG sprites HOT 1
- [Proposal] Add option to skip some phrase during encoding HOT 1
- Issues to find SVGs inside imported sass files. HOT 1
- Please update `file-loader` to latest version HOT 14
- Incorrect Data URI content when using issuer test HOT 2
- Doesn't working on image tag HOT 2
- Missing webpack in peerDependencies for yarn@2 compatibility HOT 1
- Please Add CHANGELOG.md HOT 1
- Action Required: Fix Renovate Configuration
- [Webpack]Error report of introducing SVG file into img tag ? Please refer to the screenshot. HOT 13
- "module export" instead of svg directly HOT 6
- Dependency Dashboard
- Malformed svg produced HOT 3
- Svg is abstracted from css file. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svg-url-loader.