Comments (3)
Ah, yeah I don't actually use TypeScript at all. I basically just blindly accept any pull request involving the indes.d.ts
file
from node-diff3.
Ok, I can see the issue, this is the actual line from index.d.ts (not sure why the messages show it as what I put in the original post instead):
export function patch<T>(buffer: T[], patch: IPatchRes<T>[]): Buffer<T>[];
"Buffer" is indeed an attempt to use Buffer as a generic. If the function truly returns an arrray of binary Buffer objects, the correct export would be:
export function patch<T>(buffer: T[], patch: IPatchRes<T>[]): Buffer[];
If the function returns an array of type T, which seems more consistent with the other functions, it would be
export function patch<T>(buffer: T[], patch: IPatchRes<T>[]): T[];
Happy to make the pull request if you want
from node-diff3.
Thanks, I went with T[]
as the return type.. Just published v2.1.2 with this fix
from node-diff3.
Related Issues (20)
- Tests
- An in-range update of eslint is breaking the build 🚨 HOT 2
- Version 10 of node.js has been released HOT 1
- Setup Travis
- An in-range update of rollup is breaking the build 🚨 HOT 11
- An in-range update of rollup is breaking the build 🚨 HOT 35
- Improve test coverage HOT 1
- generate separate ES5 bundle
- invertPatch modifies patch in place and it should return a copy HOT 1
- Typescript declaration file
- Create a new release to fix typescript definition issue HOT 1
- Action required: Greenkeeper could not be activated 🚨
- [Question] 2-way merge is not giving desired results. HOT 3
- How to perform a merge? HOT 1
- Creating a merge of a three-way comparison HOT 1
- Remove \n from conflict boundaries
- Tests for data with empty lines
- Diff is working weird in some scenarios?
- Incorrect merge boundary placement HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-diff3.