Comments (6)
I can take a stab at a patch later in the week if it helps.
Cheers.
Original comment by [email protected]
on 15 Sep 2010 at 12:18
from credis.
Ooops I missed that lots of people ask me if credis is thread safe and I've
told them yes, it should be... I reused an old snippet when starting on Credis
so I will gladly accept a patch that fixes this issue.
cheers,
Jonas
Original comment by [email protected]
on 15 Sep 2010 at 7:41
- Changed state: Accepted
from credis.
Question--
gethostbyname() is only called in the event that inet_aton(host, &sa.sin_addr)
fails. On my system, it doesn't fail, so I haven't had any issues with thread
safety. My question is: When would inet_aton fail that gethostbyname() would
succeed?
Cheers,
Dean
Original comment by [email protected]
on 15 Sep 2010 at 9:58
from credis.
This should do it for the non-Win build. I did not check the Win side, but I
don't think I broke anything. Shout if I messed up--still learning the ropes...
Cheers,
Dean
Original comment by [email protected]
on 18 Sep 2010 at 1:14
Attachments:
from credis.
thanks, I have taken your patch with minor changes
Original comment by [email protected]
on 21 Sep 2010 at 12:34
from credis.
Original comment by [email protected]
on 21 Sep 2010 at 12:34
- Changed state: Fixed
from credis.
Related Issues (20)
- Bloat your makefile HOT 3
- Compilation error on FreeBSD 8.1 amd64 HOT 1
- [patch] SETEX, HKEYS, HLEN and HMGET realization HOT 1
- credis_zincrby doesn't work
- Wrong command format for redis-2.2.2 HOT 6
- fixed bug in cr_push
- [patch] PERSIST, HMSET, HINCRBY and HVALS realization
- credis can't compile successfully using msvc-9.0 HOT 1
- Add sipport for Pipelining
- add support for lua scripting
- make install says not implemented HOT 1
- add keyspace_hits and keyspace_misses to credis_info command HOT 1
- credis_quit is declared but not implemented HOT 2
- Multibulk lost on publisher subscriber schema
- undefined HDEL
- HSET returns error when value is modified and shouldn't
- credis_set bug
- consider moving development to github
- credis_connect() unable to connect to redis HOT 1
- what to do after download step by step help
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from credis.