Giter Club home page Giter Club logo

bfpapertabbarcontroller's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bfpapertabbarcontroller's Issues

Problems with iPad

The tabBar property UITabBarItemPositioning has a default value of UITabBarItemPositioningAutomatic
and this value change the itemSpacing of UITabBarItems in the tabBar on the iPad, making the items centered and no longer evenly distributed along the tabBar width.

Portrait
screen shot 2014-10-05 at 21 14 40

Landscape
screen shot 2014-10-05 at 21 14 49

One possible solution is changing the value UITabBarItemPositioningAutomatic for UITabBarItemPositioningFill.
screen shot 2014-10-05 at 21 15 38

self.tabBar.itemPositioning = UITabBarItemPositioningFill;

viewDidLoad called twice in DemoTabBarController

Hi,

I really like the bFPaperTabBarController. I tried using it in a project and noticed my view controller that extends the BFPaperTabBarController is called twice.
I checked with the demo that is provide with the source code: DemoTabBarController. There the same happens.
Is there any way to prevent this? Allocating the controller twice seems a bug to me.

Regards,

Rudie.

tapCircle variable sometimes is nil

In my app sometimes this variable returns nil when the user fast switch between views, i could not reproduce the problem in the demo app, and since my views do some heavy work when loading a think it may have something to do with that process.
I made a simple change in the burstTapCircle method, just add a nil check and it seem to solve the my problem and didn't change any behavior in the component

if (tapCircle != nil) {
    [self.deathRowForCircleLayers addObject:tapCircle];


    CGPathRef startingPath = tapCircle.path;
    CGFloat startingOpacity = tapCircle.opacity;

    if ([[tapCircle animationKeys] count] > 0) {
        startingPath = [[tapCircle presentationLayer] path];
        startingOpacity = [[tapCircle presentationLayer] opacity];
    }

    // Burst tap-circle:
    CABasicAnimation *tapCircleGrowthAnimation = [CABasicAnimation animationWithKeyPath:@"path"];
    tapCircleGrowthAnimation.duration = self.touchUpAnimationDuration;
    tapCircleGrowthAnimation.timingFunction = [CAMediaTimingFunction functionWithName:kCAMediaTimingFunctionEaseOut];
    tapCircleGrowthAnimation.fromValue = (__bridge id)startingPath;
    tapCircleGrowthAnimation.toValue = (__bridge id)endingCirclePath.CGPath;
    tapCircleGrowthAnimation.fillMode = kCAFillModeForwards;
    tapCircleGrowthAnimation.removedOnCompletion = NO;

    // Fade tap-circle out:
    CABasicAnimation *fadeOut = [CABasicAnimation animationWithKeyPath:@"opacity"];
    [fadeOut setValue:@"fadeCircleOut" forKey:@"id"];
    fadeOut.delegate = self;
    fadeOut.fromValue = [NSNumber numberWithFloat:startingOpacity];
    fadeOut.toValue = [NSNumber numberWithFloat:0.f];
    fadeOut.duration = self.touchUpAnimationDuration;
    fadeOut.fillMode = kCAFillModeForwards;
    fadeOut.removedOnCompletion = NO;

    [tapCircle addAnimation:tapCircleGrowthAnimation forKey:@"animatePath"];
    [tapCircle addAnimation:fadeOut forKey:@"opacityAnimation"];

}

Registering an observer in viewWillAppear

If i try to present a new viewController from the tabBar the observer is removed when the viewWillDiappear method is called, the next time i try to present a viewController the app will crash because it will try to remove a observer that is no longer registered.

Would not it be better register an observer in the viewWillAppear method?

- (void)viewWillAppear:(BOOL)animated {
    [super viewWillAppear:animated];
    // Set up tab bar for KVO on its 'hidden' key:
    [self.tabBar addObserver:self forKeyPath:BFPaperTabBarControllerKVOKeyPath_hidden options:0 context:BFPaperTabBarControllerContext];
}

How to change inactive item color

Hi, how can i change the inactive icon text and image color/tint? I mean, i want the unselected items to be red, and the selected one to be white, but i wasnt able to change the inactive items color. Can you help me? Thanks in advance.

compile error for 9.3 beta


image

seems there's this weird error, and suggested correction didn't work. Anybody run into this issue yet?

lemme know, thank you very much!

Double tap on tab does not pop to root navigation controller

When using the default tabbar controller each tab can provide a way to pop to its inner root controller within each navigation stack, by tapping twice on each tab. Here i cannot get the same behaviour: the second tap on a tab just does nothing.

create controller programmatically throws exception

I'm experimenting with this controller and figured that it raises NSRange out of bound exception when calling alloc init. it seems that alloc init somehow calls initwithnib, which I don't have any. Is this control only supposed to be used with storyboard?

Compatibilities with swift

I working a project with swift language.
After I pod install and try to do with it, i found out some how my tab bar same as before does not have the underline below tab bar.

Why?

screen shot 2016-12-28 at 10 33 18 am

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.