Possible issue involving permissions of models with composite name about filament-shield HOT 7 CLOSED

@coolsam726 I created a PR, take a look if you have interest to use it: #74.

My fix is different of your, I kept the permissions as generated, like projectcategory. I just change some pieces of the shield's form to make it matches. Check all works too in this case.

i will definitely review it once more. But bear in mind it's not just the composite resource names but also how resources are structured... i.e. in the demo there is Blog and Shop and they both have CategoryResource... so the draft PR also takes care of that situation as well during policy and permission generation...

@coolsam726 no need it's almost done... will be out in a day or two 😇

from filament-shield.

I was able to do a dirty fix just removing the _ from $entity in RoleResource to make the fields of the form match with the permissions generated in DB and Policies, but I don't think it is the right approach for the case.

Let me know if a PR using this approach is welcome and I can create one (deniscsz@0c8a72b).

from filament-shield.

I have experienced the same issue. My quick fix was to find&replace the composite name and replace it with the snake case equivalent. In my case, from projectcategory to project_category. The permissions work, but in the settings the Check All toggle input still remains off as shown below.

This would mean every time I generate permissions and policies I will have to modify my policy again. A fix to this will be highly appreciated.

from filament-shield.

@deniscsz this issue has been resolved in the draft PR #69 which also takes care of models inside directories and such plus much more...

from filament-shield.

@coolsam726 I created a PR, take a look if you have interest to use it: #74.

My fix is different of your, I kept the permissions as generated, like projectcategory. I just change some pieces of the shield's form to make it matches. Check all works too in this case.

from filament-shield.

@bezhanSalleh Ok, thanks for let me know.

from filament-shield.

@bezhanSalleh, thanks for responding to this. Could we leave the issue open until PR #69 is merged then? Or is the fix already released?

from filament-shield.