Giter Club home page Giter Club logo

Comments (3)

antony avatar antony commented on May 23, 2024

Hi @andykillen - happy to accept a PR for this. I'm not sure why anybody would install it any other way than the first way you've documented however.

from svelte-social-auth.

andykillen avatar andykillen commented on May 23, 2024

It's that because this repo has higher search result placement (#2) than the npm version of this information, which is not on the first page on my results. Incidentally the #3 result is the "made with svelte" site, which again link to this Git repo and not npm.

It is common to just grab the path from the url on github and it work for npm. Without install instructions, or whatever, people will get it wrong.

from svelte-social-auth.

antony avatar antony commented on May 23, 2024

I would've thought the code samples in the readme would be enough to indicate the presence of an npm package.

I'm going up disagree that it's common for people to expect a github url to resolve to an npm package, it would depend on both the scope and package name being an exact match for the github org and repository name. if you are doing that I would recommend you stop, since the likely scenario is that you end up installing the package from github which will result in your application depending on the master branch (and receiving the latest master upon each install). This is incredibly dangerous, and wildly unpredictable, and for compiled packages it just won't work.

I'll add some more explicit instructions to the repository unless you are willing to open a PR to do so before I get a chance?

Thanks for spotting this.

from svelte-social-auth.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.