Giter Club home page Giter Club logo

Comments (4)

petdance avatar petdance commented on August 25, 2024

Hi, here's a patch. I have this in my ackrc:
-X-min.js$

And it works great. :-)

-- robertanthonyfarrell, 2009-04-17 11:45:31

from ack1.

petdance avatar petdance commented on August 25, 2024

Hi robertanthonyfarrel!

Your patch is reversed. Furthermore:

  1. It does not patch the .pm files but only the standalone executable.
  2. It does not include regression tests for this behaviour.

Can you correct these problems and resend?

Regards,

-- Shlomi Fish

-- shlomif, 2009-04-17 12:33:38

from ack1.

petdance avatar petdance commented on August 25, 2024

Hi, sorry about that - I'm not a Perl guy so I didn't have the pm, and I didn't
notice the big warning at the top of the file saying it was autogenerated. I can
blame the patch being reversed on my hangover. :)

Couldn't find any unit tests in the trunk - are they located elsewhere ?

Here's a svn diff attached, let me know if there's any trouble with it.

-- robertanthonyfarrell, 2009-04-17 14:16:17

from ack1.

petdance avatar petdance commented on August 25, 2024

@robert: the unit tests are located under the t/ directory. Here:

http://code.google.com/p/ack/source/browse/#svn/trunk/t

You should use Subversion and the svn diff command to generate a patch.

Regards,

-- Shlomi Fish

-- shlomif, 2009-04-19 11:16:47

from ack1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.