Unnecessary (?) alert about laravel-query-detector HOT 7 CLOSED

I pushed some commits in order to take the last stack trace frame into account.
Unfortunately, there's currently no way to fix this:

       $user = Auth()->user();
       $user->load('banks.accounts.balances', 'accounts.balances');

from laravel-query-detector.

I could reproduce it on another page, where it is a bit clearer why the data is loaded:

$user->banks->accounts->balances
$user->accounts->balances

These are two ways to get the same data. As the page is looping over ->accounts of both $user->banks and $user for two different parts of the interface, this seems to trigger the alert:

Found the following N+1 queries in this request:

Model: App\Account => Relation: App\Balance - You should add "with('AppBalance')" to eager-load this relation.

Is this expected?

from laravel-query-detector.

What do you mean by routes? Then I can try to see if this can be detected.
The problem is that I can only listen for sql queries and then need to backtrack from there.
Hmm maybe I should just use the latest stack trace location to determine if the calls are actually duplicates. That might be a good idea :)

from laravel-query-detector.

See my second post for an example of "routes": There are two ways to get from a to b via relationships in this app's relationship model. This results in the same query being fired twice, but I couldn't find a way to avoid that until now with Eloquent.

from laravel-query-detector.

In this app I can trigger the faulty behavior by just doing this:

       $user = Auth()->user();
       $user->load('banks.accounts.balances', 'accounts.balances');

from laravel-query-detector.

In this case, this package will be unable to tell the difference.
I will add the backtrack source location as another unique parameter to check. This will at least minimize this a lot, I guess.

And well, in theory you still do resolve the same relation twice.

from laravel-query-detector.

I know, but: Is there a way around that?

from laravel-query-detector.