Certificate handling about betfair HOT 6 CLOSED

Going to fix the latter on 0.9.4, which will have your pull request as well (thanks)

The cert property currently makes things easier by assuming you have your certs in a folder so all you have to do is provide a directory instead.

from betfair.

I see. I tried it again but it seems to fail because my folder has crt, crs, key, and pem files in it. Also to point to the correct directory (../certs/) I need to pass certs, since BaseClient expects the path relative to the parent directory.

It's easy to work around (made a folder with just crt and key files, passed different path as certs), but I found it confusing.

Maybe you can add two kwargs to the constructor, certs and certs_dir. Certs would be a list or tuple like for requests, but if the users passes certs_dir then you lookup the certs in the directory and set the certs property to them. (I'm happy to send a PR for this)

from betfair.

I worked a possible solution in my fork. If you like it I can open a PR for it too.

from betfair.

You able to open a PR and I will have a look my side, thanks.

from betfair.

All working my side so have pushed 0.9.4 to master, thanks!

from betfair.

It might be worth explaining the certs vs. cert_files difference somewhere. I got confused with how the parameters are used (i.e. I was passing certs='certs/' instead of certs='parentdir/certs') and I was also confused with what type of certificate format is required (I was actually using .pem files, and not .key and .crt files).

Burned a good 20 minutes looking at the code to work this out. :)

from betfair.