Use Memcache::getServerStatus() instead of fsockopen() about cachebundle HOT 2 CLOSED

The reason I initially went with fsockopen() was that connection attempts via Memcache have a default timeout of 1 second. I was aiming for sub-second page loads, even when the memcache server is offline, and fsockopen() allows me to set a Millisecond-level timeout. I see that Memcache::addServer has a timeoutms value now, but its location at the end of the function definition might make it a bit useless - you're welcome to experiment with that, though.

I did some quick benchmarks:

• Blindly trying to add a value to the (offline) server takes 1.022 seconds
• Using getServerStatus first takes 1.024 seconds
• Using fsockopen() with a 0.2s timeout takes 0.22s to determine the server is offline & ignore the request.

It might make more sense to put an "@" suppression flag on the calls to fsockopen/fclose; given that these methods are supposed to detect and ignore a timeout, the notice itself is fairly irrelevant.

from cachebundle.

The interesting thing that I found about getServerStatus() is that you have to have the server added first.

I don't actually think there's a way that we could take advantage of this function to do what the bundle is doing. Once a server is added to the pool, it seems that there's no way to remove it, so is getServerStatus() more of an awareness thing? It seems that calls to get() and set() would still fail once the server is added.

Thanks for merging the PR. This will help calm the noise in my logs right now.

from cachebundle.