Generator never hits uppercase 'A' about password-generator HOT 4 CLOSED

Thanks @ADIOP55550 for reporting this and @fshields for finding the solution to the bug. I was able to confirm it with a test case and pushed a fix to npm as 2.2.2

from password-generator.

There is a file containing result of 500 calls password-generator -c -l 50 -p "[a-zA-Z]". No 'A's!
result.txt

from password-generator.

I've run into this issue as well. In fact, It happens even with digits. For example:
generatePassword(12, false, /\d/) will never generate a password with a zero in it (despite the README showing this as an example with a "0" in the output.)

I think I've discovered more about the issue. It seems that it is dropping the character with the lowest ASCII value from the list of character choices. So if you run this:
generatePassword(12, false, /AB5/) you will get a password with only "A" and "B" characters, but never a "5" because the character "5" has a lower ASCII value than any of the other characters.

ASCII Values:
"5" - decimal 53, hex 35
"A" - decimal 65, hex 41
"B" - decimal 66, hex 42

from password-generator.

I'm pretty sure that the error lies in line 84 of /dist/password-generator.js:
if (value > min && value < max) {

The return from this function is used to select a character from a zero-based array. However, "value" can never be zero because "min" is zero; and 0 is not less than 0 (ever).

I think that line 84 should be changed to:
if (value >= min && value < max) {
so that the zero-ith element of the validChars[] array can be chosen.

from password-generator.