404 on Amber's JS and CSS files when viewing a WordPress post about amber_wordpress HOT 8 CLOSED

Thanks for the report. I believe your diagnosis is correct, and we're working on getting the fix out.

from amber_wordpress.

We just pushed 1.4.1 on WordPress. Once you update, it should be working for you.

from amber_wordpress.

Those files are successfully loading after updating the plugin, but nothing happens when I hover over a link that has been archived. The Amber Dashboard shows that links were successfully snapshotted. I set Available Links and Unavailable Links both to the "hover" setting, but nothing happens when I hover over a an archived link. Wordpress site at http://favorites.aribadernatal.com.

from amber_wordpress.

How many seconds have you set the "Hover delay" to notify the end user? For immediate display of preserved links, you might want to indicate 0 there.

If this isn't the problem, let me know and we'll keep digging.

from amber_wordpress.

It had been at 2 seconds. I changed both to 0 seconds, but still nothing pops up.

from amber_wordpress.

Hmm. @jlicht would you be able to look into this?

from amber_wordpress.

It suspect that the regexp in the filter that examines a post before it's displayed to extract URLs is getting confused by the target="_blank" that's part of the links on those pages. It gets the URLs wrong, and therefore can't find a match.

I think we'll fix this by changing the regular expression in the filter() function to use a non-greedy match.

Old:
$re = '/href=["\'](http[^\v()<>{}\[\]]+)[\'"]/i';

New:
$re = '/href=["\'](http[^\v()<>{}\[\]]+?)[\'"]/i';

from amber_wordpress.

That worked! (I modified amber.php locally to test, loaded a post, and verified that the Amber popover appears when hovering over an archived link.) Thank you for tracking this down!

from amber_wordpress.