Comments (2)
Greetings!
As Marco already pointed out, this behaviour is intended to be fully symmetrical with how postfixes operate.
We've had a plan on exposing the __skipOriginal
boolean to prefixes and postfixes instead so that prefixes themselves can decide whether skip their execution or not.
Seeing as this is closely related to that feature, I'll reopen this issue and close it again once bool __skipOriginal
parameter support is in.
Related, I've made #8 which I plan on addressing this week so that all possible differences from original Harmony is known.
from harmonyx.
This is the expected behavior in new versions. Prefix patches preventing other prefix patchers from running have been found to be very error prone and nondeterministic in more complex setups. This combination caused seemingly random crashes in plugins that did not expect their prefix patches to not run and was very difficult to diagnose and fix (different users could have the patches ordered differently because of different plugin load orders, so for some users it worked fine while it broke for others). It is also not reasonable to expect a plugin authors to know all other plugins that patch a particular method, therefore the decision was to make this change.
If you need to prevent a certain plugin's prefix patch from running the recommended way is to patch the patch itself.
from harmonyx.
Related Issues (20)
- [Wiki] Typos in section 1.4 HOT 1
- [Wiki] Error using the provided postfix in section 1.4 HOT 1
- When will v2.11.0 be published on NuGet? HOT 2
- Android IL2CPP Support
- v2.11.0: patch with "ref string" on "static external" method produces garbage HOT 5
- Harmony doesn't work when path contains non-ANSI characters HOT 1
- How do I call a private function within a postpatch HOT 8
- Harmony Unpatch and repatching causes transpiler IL errors HOT 1
- Pass-through transpiler messes up leave labels in inner `MoveNext()` with `try/finally` block HOT 2
- IDK HOT 2
- Does it support NET6? HOT 1
- Label Jump HOT 2
- Empty Transpiler Causing Issues HOT 1
- How to override explicit interface methods? HOT 1
- When did it start to support net 7 or 8? HOT 1
- Cannot unpatch extern method patch
- Patching ref parameter with IL2Cpp results in invalid IL
- Usage with unity
- Empty Harmony Annotations Cause ArguementException: No Target Method Found HOT 2
- Skipping a patch when a method isnt found HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from harmonyx.