Assembly.GetExecutingAssembly causing game to crash about harmonyx HOT 8 CLOSED

It should be fixed by #97.

from harmonyx.

If you use HarmonyX v2.12.0, that's most likely the same issue #79 (comment) which was introduced in reorg. I don't think BepInEx is using the reorg version currently? That was supposed to be fixed with 6e3726f which isn't released yet though.

Using the latest version of HarmonyX produced the same behavior as you when I was using it in our mod loader. Sometimes it was crashing Unity, sometimes it threw a null ref.

You either should use v2.10.2 or wait for the next release. v2.12.0 is broken. And it was released knowing it was broken. For some reason.

from harmonyx.

Does it work fine when loaded by BepInEx?

from harmonyx.

Yep seemed to work all fine with with BepInEx_win_x64_5.4.23.1. (I assume HarmonyX is packaged up with it by default)

using System.Reflection;
using BepInEx;

namespace BepInEx_Crash_Test
{
    [BepInPlugin(PluginInfo.PLUGIN_GUID, PluginInfo.PLUGIN_NAME, PluginInfo.PLUGIN_VERSION)]
    public class Plugin : BaseUnityPlugin
    {
        private void Awake()
        {
            // Plugin startup logic
            Logger.LogInfo($"Plugin {PluginInfo.PLUGIN_GUID} is loaded!");

            var assembly = Assembly.GetExecutingAssembly();
            Logger.LogInfo($"This is after calling {nameof(Assembly.GetExecutingAssembly)}, the result was {assembly}");
        }
    }
}

from harmonyx.

I assume HarmonyX is packaged up with it by default

Yes, it is. This means you're missing something in your launcher then.

from harmonyx.

When you say something, are you meaning maybe an assembly? Comparing with dependencies HarmonyX brings in through Nuget vs what I have installed, there isn't anything missing.

Adding this just for context of the thread, now weirdly having:

var path = Assembly.GetExecutingAssembly();
Debug.Log(path);

Throw a null error in debug.log, even though decompiled dll shows its got a null check

NullReferenceException: Object reference not set to an instance of an object
  at UnityEngine.Logger.GetString (System.Object message) [0x00032] in <72b60a3dd8cd4f12a155b761a1af9144>:0 
  at UnityEngine.Logger.Log (UnityEngine.LogType logType, System.Object message) [0x00012] in <72b60a3dd8cd4f12a155b761a1af9144>:0 
  at UnityEngine.Debug.Log (System.Object message) [0x00006] in <72b60a3dd8cd4f12a155b761a1af9144>:0 
  at Pop.HelmetPop+<LoadAudioClip>d__2.MoveNext () [0x00030] in <62d0a4dbf2a34d38ba2e27292f55322c>:0 
  at UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) [0x00026] in <72b60a3dd8cd4f12a155b761a1af9144>:0 

from harmonyx.

I don't think BepInEx is using the reorg version currently?

It is not using it yet. This might be fixed by #114 ?

from harmonyx.

Added HarmonyX source to my project and compiled at the current latest on master. Ran it three times and it didn't crash!

Closing this as I've confirmed its fixed for me. Thank you so much @Meivyn for that insight

from harmonyx.