Giter Club home page Giter Club logo

Comments (15)

bensu avatar bensu commented on August 18, 2024 2

We got green light to fix this at the compiler level! Will update here any progress.

from doo.

bensu avatar bensu commented on August 18, 2024

I think this is related to #52 and how the compiler finds/watches macro files. Since this is a little more complex, can you provide an example repo?

from doo.

exupero avatar exupero commented on August 18, 2024

I solved #52 by supplying a top-level :source-paths in my project.clj, but doo still doesn't pick up changes to .clj files. Here's an example project demonstrating the problem.

from doo.

bensu avatar bensu commented on August 18, 2024

Thanks @exupero , I'll look at it shortly.

from doo.

bensu avatar bensu commented on August 18, 2024

I was able to reproduce the behavior without using doo here. I'll see if we can fix this at the compiler level.

Reading this line it is clear why it doesn't work.

from doo.

bensu avatar bensu commented on August 18, 2024

Hey @exupero

Macro reloading is not supported by the compiler's api. I think it is an important feature and doo should support it. Since we heavily rely on the compiler's api we will try to add it to the compiler. If that effort fails, we will refactor doo accordingly. In any case, it will take time :(

Sorry for the delay, I'll keep you posted.

from doo.

exupero avatar exupero commented on August 18, 2024

Thanks for your work on this. I'm in no urgent need of a fix and can work around the problem until the right solution is found.

from doo.

bensu avatar bensu commented on August 18, 2024

Cool, we'll be tracking progress on the compiler front in CLJS-1490.

from doo.

laurentsenta avatar laurentsenta commented on August 18, 2024

Note that I encounter this issue with .cljc too,
will this fix the issue for both .clj and .cljc?

(thanks for this very handy tool btw)

from doo.

bensu avatar bensu commented on August 18, 2024

Hi @lsenta, it seems that if I manage to solve it at the compiler level it should fix the problem for both cljc and clj files.

from doo.

metasoarous avatar metasoarous commented on August 18, 2024

Awesome that you're working on this; Status updates?

I'm working on a bunch of cljs macros, and it's sooo painful...

from doo.

bensu avatar bensu commented on August 18, 2024

Hi @metasoarous

We need to go to cljs.build.api/watch and call something like this function when clj and cljc files need to be reloaded. I'll eventually get to it, but I don't know when since I've been super busy lately.

from doo.

metasoarous avatar metasoarous commented on August 18, 2024

OK; Sounds good. Looking forward to it :-)

from doo.

vemv avatar vemv commented on August 18, 2024

I'm not experiencing this issue (default config, no magic). I can touch a testing macro and suite will reload.

Issue might have become outdated?

from doo.

miikka avatar miikka commented on August 18, 2024

CLJS-1490 has been fixed. Therefore I believe this problem can be solved by upgrading to ClojureScript 1.9.198 or later. I'll close this issue now.

from doo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.