It would be nice if "width" could take a percentage value about peity HOT 9 CLOSED

Fixed by #26, only took two years!

from peity.

Yes! Absolutely! In fact it should be the default for line and bar charts.

from peity.

Thanks for the quick reply. I'm not sure if you mean it already should be the default, or you think that the default should change to 100%. In the docs here (http://benpickles.github.com/peity/) the default width for line and bar is 32px.

from peity.

I would also love to be able to set percent width.

Many sites are responsively designed these days (including mine) so setting a percent rather than pixel width would allow the peity.js charts to resize depending on browser width.

thanks @benpickles for making such a great plugin!

from peity.

Percentage width would be very useful, particularly as I use these graphs above & underneath other content which has a variable width

from peity.

I think this Stackoverflow (SO) thread answer by @6052 is the answer we are looking for.

It seems the key thing is that there are two sets of height/widths for the canvas, a JS and a CSS one.
The crappy solution is to set the canvas CSS width as a % while leaving the canvas.width and canvas.height in pixels. An example of this is shown in this JSFiddle. You'll notice that the canvas does resize when you change the browser width, its just that canvas is blurry when the browser width gets big enough.

The improvement on this seems to be to only specify the canvas.width when you know the browser width. So one implemenation could be getting the window.innerWidth and taking some pixel percentage of that?

Perhaps check out the SO thread and give your thoughts?

from peity.

FYI I'm thinking about this but haven't quite come to a final decision yet. It seems sensible to support percentage dimensions but I have to give some further thought to the implications.

from peity.

thanks, yeah it is not as simple as I originally thought...

from peity.

I have a proof of concept for using percentage dimensions, there's more work to do and I've only tried it with line charts but it looks promising - #26.

from peity.